From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE8AC433FE for ; Fri, 11 Dec 2020 16:53:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9A3D2310E for ; Fri, 11 Dec 2020 16:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9A3D2310E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knlf9-0007d6-HI for qemu-devel@archiver.kernel.org; Fri, 11 Dec 2020 11:52:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knlZo-0004nS-JJ for qemu-devel@nongnu.org; Fri, 11 Dec 2020 11:47:28 -0500 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:44466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knlZn-0002BY-1B for qemu-devel@nongnu.org; Fri, 11 Dec 2020 11:47:28 -0500 Received: by mail-ej1-x643.google.com with SMTP id w1so8567843ejf.11 for ; Fri, 11 Dec 2020 08:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FtFahMWUkxRH3ltuNlCugR+DBs5lwmd7BUQy5DiOZ9c=; b=oEhS7gSVpRHn5YciAEauWSPvNlb6NMI3u3nz+nSmMFdkU48Q0XTJQ5f46/YSJXRvhG DEHe8GGWNQTANnSttuCDUmIHvbkr8wP/U00AzbObK7VCTjzBQOLiiycmDAxMOZ11SoCW Zq8qH3MPEs4IEda/6YMxjQ8ZxRSXBDdjobDEc9YVSwY5AlRN4cY/CAPE2Xh3GQCYmeNV VOGfwDmIz1D2muoT/0Vz4cfLJ3cw6skyJ80ktaEd5XpIB+3D8qqNqVYXv99eVpc40MTe 8c7YOZIWWXQnclZjAOOIvFpWyvSF9qIHe+hrsPDCf/yv8AH6xjR3V/4NuK3lDCuw72Fm DXAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FtFahMWUkxRH3ltuNlCugR+DBs5lwmd7BUQy5DiOZ9c=; b=ghcPbG1+CegZv4OJXpufZDp7k1DcT3vUUY/bBEiCxQy6glaEUwOu0jDWIFy2KZuZuH lkxW8y72qBNAlbHHOwScsDnBJVGciNZAbQVjXYJnnkBSbXaXPQZtGmj+Y+kL8+7lp5/T 7LyBe/JUmcoFX3FTkuT6PrpD9DjqNFMa0l18TZhQ/yDMh7jkseq1t9jcbJtVVr35R4ED J/sfbD09FHOzaC0RmsuirfqYL2kRkRCzm1idr8eQFmtgG2LYILwmunp3UOc8jXxnZkgR MNMDUOl1KpjOP9hm+U0OV7AJ7fWzJbm4dR3d7WEdfHDM8V53eiKGbGRxIxu7Ypib665a Q6DA== X-Gm-Message-State: AOAM533WDFs4uDtdFNNso9i4ZuXb6mz+73IvrtXmHxpWrs5EgLTP5PKG ife9rG910HBD9jhFHkO0Dof/vi36L9wCd1EELod7Yg== X-Google-Smtp-Source: ABdhPJz88uoPi41E2TBxcqWQRxIgqb7FwpTwaRb1iY72DSopew71QLLahlPGtFi31sThRRdG8jSKaW5Ckob4lyUR1lQ= X-Received: by 2002:a17:906:6b88:: with SMTP id l8mr11831626ejr.482.1607705245328; Fri, 11 Dec 2020 08:47:25 -0800 (PST) MIME-Version: 1.0 References: <20201208122306.8933-1-leif@nuviainc.com> <20201208122306.8933-4-leif@nuviainc.com> <20201211161236.GT1664@vanye> In-Reply-To: <20201211161236.GT1664@vanye> From: Peter Maydell Date: Fri, 11 Dec 2020 16:47:13 +0000 Message-ID: Subject: Re: [PATCH 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h To: Leif Lindholm Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::643; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x643.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rebecca Cran , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 11 Dec 2020 at 16:12, Leif Lindholm wrote: > > On Fri, Dec 11, 2020 at 14:45:55 +0000, Peter Maydell wrote: > > On Tue, 8 Dec 2020 at 12:23, Leif Lindholm wrote: > > > > > > Signed-off-by: Leif Lindholm > > > +FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 20) > > > > The ASSOCIATIVITY field is bits [23:3], so it's > > 21 bits long, not 20, right ? > > Err, indeed. > > > > +FIELD(CCSIDR_EL1, NUMSETS, 32, 23) > > > > Similarly, NUMSETS is [55:32] so 24 bits long. > > Sorry, brain must have taken holiday. > > Would you like a v2 of this patch, fixing those? Yes please. > > > + > > > +FIELD(CTR_EL0, IMINLINE, 0, 4) > > > +FIELD(CTR_EL0, L1IP, 14, 2) > > > +FIELD(CTR_EL0, DMINLINE, 16, 4) > > > +FIELD(CTR_EL0, ERG, 20, 4) > > > +FIELD(CTR_EL0, CWG, 24, 4) > > > +FIELD(CTR_EL0, IDC, 28, 1) > > > +FIELD(CTR_EL0, DIC, 29, 1) > > > + > > > FIELD(MIDR_EL1, REVISION, 0, 4) > > > FIELD(MIDR_EL1, PARTNUM, 4, 12) > > > FIELD(MIDR_EL1, ARCHITECTURE, 16, 4) > > > > Any reason not to define the other fields here? > > FIELD(MIDR_EL1, VARIANT, 20, 4) > > FIELD(MIDR_EL1, IMPLEMENTER, 24, 8) > > Those are just context, not added by this patch. > (Glad to see I'm not the only one making that mistake...) Doh! thanks -- PMM