From: Peter Maydell <peter.maydell@linaro.org>
To: tobias.roehmel@rwth-aachen.de
Cc: qemu-devel@nongnu.org, "Tobias Röhmel" <quic_trohmel@quicinc.com>
Subject: Re: [PATCH v4 0/7] Add ARM Cortex-R52 CPU
Date: Fri, 18 Nov 2022 15:03:56 +0000 [thread overview]
Message-ID: <CAFEAcA-au-HysW2vdDdy1cmMAq8S_qzK-xs177AGaQ4n_Ex86w@mail.gmail.com> (raw)
In-Reply-To: <20221023153659.121138-1-tobias.roehmel@rwth-aachen.de>
On Sun, 23 Oct 2022 at 16:37, <tobias.roehmel@rwth-aachen.de> wrote:
>
> From: Tobias Röhmel <quic_trohmel@quicinc.com>
>
> Thanks again for all the help!
>
> Here is v4:
> 2. Made patch cleaner
> 3. Changed commit message
> 4. Replaced V8_R flag with ARM_FEATURE_PMSA|ARM_FEATURE_V8
> 5.
> Reworked the code to use existing pmsav7 variables
> Added migration support
> Added VSCTLR:
> I didn't add any functionality for it because I think
> Qemu doesn't model the behaviour it influences.
> 6.
> Lots of cleanup. I think I overcomplicated this a bit because
> of a misunderstanding. I thought HCR_VM is independent of enabling
> the different MPUs, but I see now that it doesn't make sense to enable
> HCR_VM when the MPUs are not enabled. I also think that there is an Error
> in the armv8-r manual supplement in Figure C1-3. With all that figured out
> the code for pmsav8r doesn't look that different from pmsav7 :)
I've now reviewed this version of the patchset; it's getting
quite close now, I think. Sorry it took me so long to get back to it.
-- PMM
prev parent reply other threads:[~2022-11-18 15:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 15:36 [PATCH v4 0/7] Add ARM Cortex-R52 CPU tobias.roehmel
2022-10-23 15:36 ` [PATCH v4 1/7] target/arm: Don't add all MIDR aliases for cores that immplement PMSA tobias.roehmel
2022-10-23 23:06 ` Richard Henderson
2022-10-23 15:36 ` [PATCH v4 2/7] target/arm: Make RVBAR available for all ARMv8 CPUs tobias.roehmel
2022-11-14 17:04 ` Peter Maydell
2022-10-23 15:36 ` [PATCH v4 3/7] target/arm: Make stage_2_format for cache attributes optional tobias.roehmel
2022-11-14 17:13 ` Peter Maydell
2022-10-23 15:36 ` [PATCH v4 4/7] target/arm: Enable TTBCR_EAE for ARMv8-R AArch32 tobias.roehmel
2022-11-14 17:19 ` Peter Maydell
2022-11-15 11:37 ` Philippe Mathieu-Daudé
2022-11-15 12:01 ` Daniel P. Berrangé
2022-10-23 15:36 ` [PATCH v4 5/7] target/arm: Add PMSAv8r registers tobias.roehmel
2022-11-18 13:52 ` Peter Maydell
2022-10-23 15:36 ` [PATCH v4 6/7] target/arm: Add PMSAv8r functionality tobias.roehmel
2022-11-18 15:03 ` Peter Maydell
2022-10-23 15:36 ` [PATCH v4 7/7] target/arm: Add ARM Cortex-R52 CPU tobias.roehmel
2022-11-18 14:04 ` Peter Maydell
2022-11-18 15:03 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-au-HysW2vdDdy1cmMAq8S_qzK-xs177AGaQ4n_Ex86w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_trohmel@quicinc.com \
--cc=tobias.roehmel@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).