From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B600C71155 for ; Tue, 1 Dec 2020 11:55:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64F952080A for ; Tue, 1 Dec 2020 11:55:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GDqc/6st" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64F952080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kk4Fj-0004fT-5I for qemu-devel@archiver.kernel.org; Tue, 01 Dec 2020 06:55:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kk4Et-0004Df-Iv for qemu-devel@nongnu.org; Tue, 01 Dec 2020 06:54:35 -0500 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:36725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kk4Eq-0006tK-Pb for qemu-devel@nongnu.org; Tue, 01 Dec 2020 06:54:35 -0500 Received: by mail-ej1-x641.google.com with SMTP id lt17so3559743ejb.3 for ; Tue, 01 Dec 2020 03:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BSp+fq8LvCYxL+tAjipD3SNRBEkrUwAJlgzMD1hu4No=; b=GDqc/6stCinaXZb07ex33bw3JlhuLZmgquF34i87+FjBf26yioFj++a2nWHCVBad9C ZjNUNectCWXeQkPuvZaasOz4Z9cj0gKoPKbpsR/6msJ6Vor0iY5rtU2YEVRRqR+jsxpa iV9UG/tVd1W6B1aq9NY+yhxyB+Jv6Q8WO/ItE666E1wSyWDGJk6JfXqeQZ2dDrt8gF7n RIgnPaAntGOlhZ2e6QmqyNe+LvMA8zj7Te7ICYMsQGJpvLl9uDtaaXpf7ePPQcmCoQtn DquJU//zOzthljwxD/5XUcHH++fk3GFccNBbDI2CLK8iwRQ3Wj/HdGkJiD8UdmX1j9p9 AhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BSp+fq8LvCYxL+tAjipD3SNRBEkrUwAJlgzMD1hu4No=; b=hVK7CQNalmBanH5pdKBgl+am0tv2yrcyTD7Siq98T93tvQuBLTk0NVR+ksL1r/sp4I pphunbfcF/xiGU+482noGhGY7YYbL1s1ismt/UOU+U/LTvnx6Q6nNUEUbA+NadFA+Aqx bSCs++gGNMUF2XDhSG6brFuGvaoDFyimN3Pd/mK0Q0SrH9IAIE6J4SrioBv9VrLsrxrl V5IPE331CBptkG/IZV+UObUgRYC39sZlqlj9hQ2IzeB1qLIFAtLLQNleHu+OFPg7xd4E 8mQUf7LUskmMXbtTnafA36OiI4FBxIuyX+PLejpXs9BCib8FssA4v/OqutEZMGtUyDER fhSg== X-Gm-Message-State: AOAM5324aabu7h4XPiWxp6De3e8MFgte7SBVKr1sZTunccX5qjKtBAhK L9EtnhQ59bPapWrfhl/ilaEftLxqP5sfGxBNj3gNXg== X-Google-Smtp-Source: ABdhPJxq425o/0S4gddVffNbNVH9SInCANGpqpelDExjknpcgteEd0bqb2+W3D3pfYNWcDkwUqGHTUkgsz57EVyWvvQ= X-Received: by 2002:a17:906:b53:: with SMTP id v19mr2689197ejg.250.1606823671071; Tue, 01 Dec 2020 03:54:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Peter Maydell Date: Tue, 1 Dec 2020 11:54:20 +0000 Message-ID: Subject: Re: [PATCH 06/11] monitor/i386: use debug APIs when accessing guest memory To: Ashish Kalra Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Lendacky , Brijesh Singh , Eduardo Habkost , kvm-devel , "Michael S. Tsirkin" , Marcelo Tosatti , Markus Armbruster , QEMU Developers , ssg.sos.patches@amd.com, Paolo Bonzini , "Dr. David Alan Gilbert" , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 16 Nov 2020 at 19:29, Ashish Kalra wrote: > > From: Brijesh Singh > > Update the HMP commands to use the debug version of APIs when accessing > guest memory. > > Signed-off-by: Brijesh Singh > Signed-off-by: Ashish Kalra > --- > monitor/misc.c | 4 ++-- > softmmu/cpus.c | 2 +- > target/i386/monitor.c | 54 ++++++++++++++++++++++++------------------- > 3 files changed, 33 insertions(+), 27 deletions(-) > > diff --git a/monitor/misc.c b/monitor/misc.c > index 32e6a8c13d..7eba3a6fce 100644 > --- a/monitor/misc.c > +++ b/monitor/misc.c > @@ -824,8 +824,8 @@ static void hmp_sum(Monitor *mon, const QDict *qdict) > > sum = 0; > for(addr = start; addr < (start + size); addr++) { > - uint8_t val = address_space_ldub(&address_space_memory, addr, > - MEMTXATTRS_UNSPECIFIED, NULL); > + uint8_t val; > + cpu_physical_memory_read_debug(addr, &val, 1); Don't introduce new uses of cpu_* memory read/write functions, please. They're an old API that has some flaws, like not being able to report read/write access errors. If debug accesses are accesses with a MemTxAttrs that says debug=1, then you should just provide the right MemTxAttrs here. thanks -- PMM