From: Peter Maydell <peter.maydell@linaro.org>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v2] target/arm: Avoid target_ulong for physical address lookups
Date: Mon, 30 Sep 2024 13:28:53 +0100 [thread overview]
Message-ID: <CAFEAcA-ba6OaxgmO5HeEOu=kNNwL9sVjzOSJAFbW2X586_+QvA@mail.gmail.com> (raw)
In-Reply-To: <20240927071051.1444768-1-ardb+git@google.com>
On Fri, 27 Sept 2024 at 08:11, Ard Biesheuvel <ardb+git@google.com> wrote:
>
> From: Ard Biesheuvel <ardb@kernel.org>
>
> target_ulong is typedef'ed as a 32-bit integer when building the
> qemu-system-arm target, and this is smaller than the size of an
> intermediate physical address when LPAE is being used.
>
> Given that Linux may place leaf level user page tables in high memory
> when built for LPAE, the kernel will crash with an external abort as
> soon as it enters user space when running with more than ~3 GiB of
> system RAM.
>
> So replace target_ulong with vaddr in places where it may carry an
> address value that is not representable in 32 bits.
>
> Fixes: f3639a64f602ea ("target/arm: Use softmmu tlbs for page table walking")
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Applied to target-arm.next, thanks (and tagged as for stable).
-- PMM
next prev parent reply other threads:[~2024-09-30 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 7:10 [PATCH v2] target/arm: Avoid target_ulong for physical address lookups Ard Biesheuvel
2024-09-30 12:28 ` Peter Maydell [this message]
2024-10-03 15:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-ba6OaxgmO5HeEOu=kNNwL9sVjzOSJAFbW2X586_+QvA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).