From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6Zw-0006lQ-6y for qemu-devel@nongnu.org; Tue, 13 Oct 2015 16:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm6Zr-00016w-D1 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 16:53:48 -0400 Received: from mail-vk0-f46.google.com ([209.85.213.46]:36384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6Zr-00016j-0i for qemu-devel@nongnu.org; Tue, 13 Oct 2015 16:53:43 -0400 Received: by vkex70 with SMTP id x70so11208977vke.3 for ; Tue, 13 Oct 2015 13:53:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1443123824-26866-1-git-send-email-cov@codeaurora.org> References: <1430417667-4245-5-git-send-email-christopher.covington@linaro.org> <1443123824-26866-1-git-send-email-cov@codeaurora.org> From: Peter Maydell Date: Tue, 13 Oct 2015 21:53:22 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] target-arm: Use common CPU cycle infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christopher Covington Cc: Paolo Bonzini , Peter Crosthwaite , QEMU Developers , Alistair Francis On 24 September 2015 at 20:43, Christopher Covington wrote: > cpu_get_ticks() provides a common interface across targets for > calculating CPU cycles. Using this fixes PMCCNTR reads when -icount > is specified (previously a non-increasing value was returned). > > Signed-off-by: Christopher Covington > --- > target-arm/helper.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) So, I think the conclusion from this thread was that we should (a) change the default cpu_get_host_ticks() implementation to call get_clock() (b) rebase this patch and apply it Is anybody planning to do that? In any case, I'm taking this thread off my "must-review" list :-) thanks -- PMM