From: Peter Maydell <peter.maydell@linaro.org>
To: Patrick Venture <venture@google.com>
Cc: hskinnemoen@google.com, kfting@nuvoton.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org, jasowang@redhat.com,
"Hao Wu" <wuhaotsh@google.com>,
"Phil Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2] hw/net: npcm7xx_emc: set MAC in register space
Date: Tue, 2 May 2023 11:03:32 +0100 [thread overview]
Message-ID: <CAFEAcA-c1fYqxaeJrWntfhhna9i4nb35MXtn6YTS6MrH8KYyww@mail.gmail.com> (raw)
In-Reply-To: <CAO=notw1yJeKPdjU65dAXbDgY0y8u1s5MDCcymLqCiw=pTcRiw@mail.gmail.com>
On Tue, 25 Apr 2023 at 21:49, Patrick Venture <venture@google.com> wrote:
>
>
>
> On Thu, Oct 6, 2022 at 6:18 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> On Mon, 3 Oct 2022 at 18:38, Patrick Venture <venture@google.com> wrote:
>> >
>> > The MAC address set from Qemu wasn't being saved into the register space.
>> >
>> > Reviewed-by: Hao Wu <wuhaotsh@google.com>
>> > Signed-off-by: Patrick Venture <venture@google.com>
>> > ---
>> > v2: only set the registers from qemu on reset
>> > once registers set, only read and write to them
>>
>>
>>
>> Applied to target-arm.next, thanks.
>
>
> I think this was missed. Please take a look.
Oops, I'm not sure where that got lost. I've applied it
to target-arm.next for real this time. (I corrected the
placement of the variable declaration but have not made
the changes to use the ld*_p/st*_p functions Philippe suggests,
because in this patch we're just moving that bit of code
from one place to another.)
thanks
-- PMM
next prev parent reply other threads:[~2023-05-02 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 17:38 [PATCH v2] hw/net: npcm7xx_emc: set MAC in register space Patrick Venture
2022-10-06 13:18 ` Peter Maydell
2023-04-25 20:49 ` Patrick Venture
2023-05-02 10:03 ` Peter Maydell [this message]
2023-04-25 23:48 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-c1fYqxaeJrWntfhhna9i4nb35MXtn6YTS6MrH8KYyww@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=hskinnemoen@google.com \
--cc=jasowang@redhat.com \
--cc=kfting@nuvoton.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).