From: Peter Maydell <peter.maydell@linaro.org>
To: gengdongjiu <gengdongjiu@huawei.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
kvm-devel <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Xu Wei <xuwei5@hisilicon.com>, qemu-arm <qemu-arm@nongnu.org>,
James Morse <james.morse@arm.com>,
Huangshaoyu <huangshaoyu@huawei.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Zhengqiang (turing)" <zhengqiang10@huawei.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v14 5/9] target-arm: kvm64: inject synchronous External Abort
Date: Thu, 11 Jan 2018 09:53:00 +0000 [thread overview]
Message-ID: <CAFEAcA-cAgB5TigMWUsnF74YrzWGToDht61HhOnGrSD1QBDNhg@mail.gmail.com> (raw)
In-Reply-To: <558dc576-6d05-50d4-9f7c-73738e28ad26@huawei.com>
On 11 January 2018 at 05:59, gengdongjiu <gengdongjiu@huawei.com> wrote:
> Hi Peter.
>
> On 2018/1/10 1:30, Peter Maydell wrote:
>> On 28 December 2017 at 05:54, Dongjiu Geng <gengdongjiu@huawei.com> wrote:
>>> +
>>> + /* This exception comes from lower or current exception level. */
>>> + if ((cpsr & 0xf) == PSTATE_MODE_EL0t) {
>>
>> This looks like it'll be wrong for AArch32 guests (which you can
>> still have with KVM with a 64-bit host), and even for AArch32
>> userspace in a 64-bit guest. The correct way to find out what the
>> current EL is is to use arm_current_el().
> sorry, in the OS(include guest OS), for software error recovery,
> we only support AArch64 kernel, not support AArch32
> kernel or AArch32 user space.
Nope, you must handle AArch32 EL1 correctly in some way, even if that
is only "this guest CPU doesn't support RAS notification and we
will not notify it". And you must absolutely support AArch32 EL0,
that's a requirement for getting this merged. It's not difficult.
thanks
-- PMM
next prev parent reply other threads:[~2018-01-11 9:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 5:54 [Qemu-devel] [PATCH v14 0/9] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 1/9] ACPI: add some GHES structures and macros definition Dongjiu Geng
2017-12-28 12:29 ` Igor Mammedov
2018-01-03 10:29 ` gengdongjiu
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 2/9] ACPI: Add APEI GHES table generation and CPER record support Dongjiu Geng
2017-12-28 14:18 ` Igor Mammedov
2017-12-29 6:33 ` gengdongjiu
2018-01-03 2:21 ` gengdongjiu
2018-01-03 13:31 ` Igor Mammedov
2018-01-04 4:21 ` gengdongjiu
2018-01-09 16:51 ` Peter Maydell
2018-01-10 5:22 ` gengdongjiu
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 3/9] docs: APEI GHES generation and CPER record description Dongjiu Geng
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 4/9] ACPI: enable APEI GHES in the configure file Dongjiu Geng
2018-01-09 17:16 ` Peter Maydell
2018-01-10 12:20 ` gengdongjiu
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 5/9] target-arm: kvm64: inject synchronous External Abort Dongjiu Geng
2017-12-28 13:49 ` Igor Mammedov
2017-12-29 6:27 ` gengdongjiu
2018-01-09 17:30 ` Peter Maydell
2018-01-11 5:59 ` gengdongjiu
2018-01-11 9:53 ` Peter Maydell [this message]
2018-01-11 10:33 ` [Qemu-devel] [Qemu-arm] " gengdongjiu
2018-01-13 5:24 ` [Qemu-devel] " gengdongjiu
2018-01-13 8:27 ` gengdongjiu
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 6/9] Move related hwpoison page functions to accel/kvm/ folder Dongjiu Geng
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 7/9] ARM: ACPI: Add GPIO notification type for hardware RAS error Dongjiu Geng
2017-12-28 14:53 ` Igor Mammedov
2018-01-03 3:48 ` gengdongjiu
2018-01-03 13:36 ` Igor Mammedov
2018-01-04 4:55 ` gengdongjiu
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 8/9] hw/arm/virt: Add RAS platform version for migration Dongjiu Geng
2017-12-28 14:58 ` Igor Mammedov
2018-01-03 4:02 ` gengdongjiu
2018-01-09 15:42 ` Peter Maydell
2017-12-28 5:54 ` [Qemu-devel] [PATCH v14 9/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng
2017-12-28 15:07 ` Igor Mammedov
2018-01-03 9:13 ` gengdongjiu
2018-01-03 13:44 ` Igor Mammedov
2018-01-04 6:31 ` gengdongjiu
2018-01-09 17:14 ` Peter Maydell
2018-01-10 11:56 ` gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-cAgB5TigMWUsnF74YrzWGToDht61HhOnGrSD1QBDNhg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=ehabkost@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=huangshaoyu@huawei.com \
--cc=imammedo@redhat.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=xuwei5@hisilicon.com \
--cc=zhaoshenglong@huawei.com \
--cc=zhengqiang10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).