Re: [PATCH 4/7] hw/pci-host: add Nuvoton PCIe root port

[Peter Maydell <peter.maydell@linaro.org>]

On Tue, 9 Sept 2025 at 23:11, Yubin Zou <yubinz@google.com> wrote:
>
> From: Titus Rwantare <titusr@google.com>
>
> Signed-off-by: Titus Rwantare <titusr@google.com>

> --- a/hw/pci-host/npcm_pcierc.c
> +++ b/hw/pci-host/npcm_pcierc.c
> @@ -203,6 +203,7 @@ static void npcm_pcierc_write_window(NPCMPCIERCState *s, hwaddr addr,
>      npcm_pcie_update_window_maps(s);
>  }
>
> +/* read root complex configuration registers */
>  static uint64_t npcm_pcierc_cfg_read(void *opaque, hwaddr addr, unsigned size)
>  {
>      NPCMPCIERCState *s = NPCM_PCIERC(opaque);
> @@ -248,6 +249,7 @@ static uint64_t npcm_pcierc_cfg_read(void *opaque, hwaddr addr, unsigned size)
>      return ret;
>  }
>
> +/* write root complex configuration registers */
>  static void npcm_pcierc_cfg_write(void *opaque, hwaddr addr, uint64_t data,
>                                    unsigned size)
>  {

These comments look like they should have been in
a previous patch where the functions were added.

thanks
-- PMM