* Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation [not found] <1401291744-14314-1-git-send-email-sw@weilnetz.de> @ 2014-06-19 8:55 ` Peter Maydell 2014-06-19 11:31 ` Stefan Weil 0 siblings, 1 reply; 3+ messages in thread From: Peter Maydell @ 2014-06-19 8:55 UTC (permalink / raw) To: Stefan Weil Cc: Stanislav Vorobiov, QEMU Developers, Stefan Hajnoczi, Sangho Park On 28 May 2014 16:42, Stefan Weil <sw@weilnetz.de> wrote: > Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a > performance degradation caused by bad handling of small timeouts > in the original implementation of g_poll. > > Since that commit, hard disk I/O no longer works. > > Instead of rewriting the g_poll implementation, this patch simply copies > the original code (released under LGPL) from latest glib and only modifies > it where needed (see comments in the code). URL of the original code: > https://git.gnome.org/browse/glib/tree/glib/gpoll.c > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > > v2: Adjust top-of-file comment to indicate which parts of the code use > a different license (LGPL2+ is incompatible with the original license > used for util/oslib-win32.c). Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Oops, I'd forgotten about this (until I needed to do something with the Windows build ;-)). Are you planning a pullreq for it or do you want me to just apply it directly? thanks -- PMM ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation 2014-06-19 8:55 ` [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation Peter Maydell @ 2014-06-19 11:31 ` Stefan Weil 2014-06-19 14:56 ` Peter Maydell 0 siblings, 1 reply; 3+ messages in thread From: Stefan Weil @ 2014-06-19 11:31 UTC (permalink / raw) To: Peter Maydell Cc: Stanislav Vorobiov, QEMU Developers, Stefan Hajnoczi, Sangho Park Am 19.06.2014 10:55, schrieb Peter Maydell: > On 28 May 2014 16:42, Stefan Weil <sw@weilnetz.de> wrote: >> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a >> performance degradation caused by bad handling of small timeouts >> in the original implementation of g_poll. >> >> Since that commit, hard disk I/O no longer works. >> >> Instead of rewriting the g_poll implementation, this patch simply copies >> the original code (released under LGPL) from latest glib and only modifies >> it where needed (see comments in the code). URL of the original code: >> https://git.gnome.org/browse/glib/tree/glib/gpoll.c >> >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> >> v2: Adjust top-of-file comment to indicate which parts of the code use >> a different license (LGPL2+ is incompatible with the original license >> used for util/oslib-win32.c). > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > Oops, I'd forgotten about this (until I needed to do > something with the Windows build ;-)). Are you planning > a pullreq for it or do you want me to just apply it directly? > > thanks > -- PMM Please apply it directly. Thanks, Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation 2014-06-19 11:31 ` Stefan Weil @ 2014-06-19 14:56 ` Peter Maydell 0 siblings, 0 replies; 3+ messages in thread From: Peter Maydell @ 2014-06-19 14:56 UTC (permalink / raw) To: Stefan Weil Cc: Stanislav Vorobiov, QEMU Developers, Stefan Hajnoczi, Sangho Park On 19 June 2014 12:31, Stefan Weil <sw@weilnetz.de> wrote: > Am 19.06.2014 10:55, schrieb Peter Maydell: >> Oops, I'd forgotten about this (until I needed to do >> something with the Windows build ;-)). Are you planning >> a pullreq for it or do you want me to just apply it directly? > Please apply it directly. Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-19 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1401291744-14314-1-git-send-email-sw@weilnetz.de>
2014-06-19 8:55 ` [Qemu-devel] [PATCH v2] w32: Fix regression caused by new g_poll implementation Peter Maydell
2014-06-19 11:31 ` Stefan Weil
2014-06-19 14:56 ` Peter Maydell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).