Re: [Qemu-devel] [PATCH V5] net/colo-compare.c: Fix memory leak and code style issue.

[Peter Maydell <peter.maydell@linaro.org>]

On Tue, 23 Jul 2019 at 04:24, Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2019/7/23 上午2:38, Zhang, Chen wrote:
> >
> >
> >> -----Original Message-----
> >> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> >> Sent: Tuesday, July 23, 2019 1:25 AM
> >> To: Zhang, Chen <chen.zhang@intel.com>
> >> Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; Jason Wang <jasowang@redhat.com>;
> >> qemu-dev <qemu-devel@nongnu.org>; Zhang Chen <zhangckid@gmail.com>
> >> Subject: Re: [PATCH V5] net/colo-compare.c: Fix memory leak and code style
> >> issue.
> >>
> >> On Mon, 22 Jul 2019 at 18:23, Zhang Chen <chen.zhang@intel.com> wrote:
> >>> From: Zhang Chen <chen.zhang@intel.com>
> >>>
> >>> This patch to fix the origin "char *data" memory leak, code style
> >>> issue and add necessary check here.
> >>> Reported-by: Coverity (CID 1402785)
> >>>
> >>> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> >>> ---
> >>>   net/colo-compare.c | 27 ++++++++++++++++++++-------
> >>>   1 file changed, 20 insertions(+), 7 deletions(-)
> >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >>
> >> Thanks for your patience in sending out all these versions as we worked
> >> through the code review process.
> > Thank you too~
> > Maybe you or Jason can pick up this patch?

> Applied.

Thanks. This is now our last outstanding coverity issue --
are you planning to send this in for rc3 ?

-- PMM