From: Peter Maydell <peter.maydell@linaro.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Markus Armbruster <armbru@redhat.com>,
pbonzini@redhat.com, qemu-devel@nongnu.org,
richard.henderson@linaro.org
Subject: Re: [PATCH v4 01/11] reset: allow registering handlers that aren't called by snapshot loading
Date: Tue, 25 Oct 2022 13:26:18 +0100 [thread overview]
Message-ID: <CAFEAcA-cqzoEyWiCd0RCGezqijvWfnXso1kH9zDb9fYdYpa_6w@mail.gmail.com> (raw)
In-Reply-To: <Y1fR/bMo/HcDvo7A@zx2c4.com>
On Tue, 25 Oct 2022 at 13:09, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Hi Markus,
>
> On Tue, Oct 25, 2022 at 08:11:51AM +0200, Markus Armbruster wrote:
> > > diff --git a/qapi/run-state.json b/qapi/run-state.json
> > > index 49989d30e6..e44c0de914 100644
> > > --- a/qapi/run-state.json
> > > +++ b/qapi/run-state.json
> > > @@ -86,12 +86,15 @@
> > > # ignores --no-reboot. This is useful for sanitizing
> > > # hypercalls on s390 that are used during kexec/kdump/boot
> > > #
> > > +# @snapshot-load: A snapshot is being loaded by the record & replay
> > > +# subsystem; internal value (since 7.2)
> > > +#
> >
> > If "internal value" was an established way to mark parts that aren't
> > visible externally, this would do. Since it isn't, it's too terse.
> > Suggest something like "This value is used only within QEMU. It doesn't
> > occur in QMP."
>
> Thanks for the precise text. I can do that for a v5, or, Peter - do you
> want to just fold that in upon committing these patches?
If there's no other issues with the series I'll just fold that change in.
-- PMM
next prev parent reply other threads:[~2022-10-25 12:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 0:43 [PATCH v4 00/11] rerandomize RNG seeds on reboot and handle record&replay Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 01/11] reset: allow registering handlers that aren't called by snapshot loading Jason A. Donenfeld
2022-10-25 6:11 ` Markus Armbruster
2022-10-25 12:09 ` Jason A. Donenfeld
2022-10-25 12:26 ` Peter Maydell [this message]
2022-10-25 12:32 ` Jason A. Donenfeld
2022-10-25 12:34 ` Peter Maydell
2022-10-25 12:42 ` Jason A. Donenfeld
2022-10-25 12:50 ` Jason A. Donenfeld
2022-10-25 13:54 ` Peter Maydell
2022-10-25 13:58 ` Jason A. Donenfeld
2022-10-25 15:19 ` Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 02/11] device-tree: add re-randomization helper function Jason A. Donenfeld
2022-10-25 1:32 ` Alistair Francis
2022-10-25 13:30 ` Philippe Mathieu-Daudé
2022-10-25 13:32 ` Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 03/11] x86: do not re-randomize RNG seed on snapshot load Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 04/11] arm: re-randomize rng-seed on reboot Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 05/11] riscv: " Jason A. Donenfeld
2022-10-25 1:31 ` Alistair Francis
2022-10-25 0:43 ` [PATCH v4 06/11] m68k/virt: do not re-randomize RNG seed on snapshot load Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 07/11] m68k/q800: " Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 08/11] mips/boston: re-randomize rng-seed on reboot Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 09/11] mips/malta: pass RNG seed via env var and re-randomize " Jason A. Donenfeld
2022-10-25 16:46 ` Peter Maydell
2022-10-25 16:56 ` Jason A. Donenfeld
2022-10-25 17:28 ` [PATCH v5] " Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 10/11] openrisc: re-randomize rng-seed " Jason A. Donenfeld
2022-10-25 0:43 ` [PATCH v4 11/11] rx: " Jason A. Donenfeld
2022-10-25 16:39 ` [PATCH v4 00/11] rerandomize RNG seeds on reboot and handle record&replay Peter Maydell
2022-10-25 16:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-cqzoEyWiCd0RCGezqijvWfnXso1kH9zDb9fYdYpa_6w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Jason@zx2c4.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).