From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Jean-Christophe DUBOIS <jcd@tribudubois.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.
Date: Sat, 4 May 2013 09:29:07 +0100 [thread overview]
Message-ID: <CAFEAcA-dLOS8LmoB86uJu3GtwkrBZ7cWjYN1HKrcx=tchhErUQ@mail.gmail.com> (raw)
In-Reply-To: <5184C674.2080007@suse.de>
On 4 May 2013 09:27, Andreas Färber <afaerber@suse.de> wrote:
> Am 04.05.2013 10:22, schrieb Jean-Christophe DUBOIS:
>> Do you mean arm_load_kernel() should test for qtest_enable() or should I
>> call arm_load_kernel() only if !qtest_enable() (there is not much
>> platform checking for qtest_enable() at this time and it seems somebody
>> need to set the "entry" field in the info struct).
>
> In short, qtest does not execute any code, so it does not need to load
> binaries or set CPU entry addresses.
>
> Yes, I would say there is no point calling arm_load_kernel() if
> !qtest_enabled().
I'd rather we didn't end up with qtest_enabled() checks infecting
every board model, please...
thanks
-- PMM
next prev parent reply other threads:[~2013-05-04 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 19:53 [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator Jean-Christophe DUBOIS
2013-05-02 12:16 ` Peter Crosthwaite
2013-05-02 18:33 ` Jean-Christophe DUBOIS
2013-05-02 23:58 ` Peter Crosthwaite
2013-05-03 12:35 ` Andreas Färber
2013-05-02 12:38 ` Andreas Färber
2013-05-03 15:16 ` Jean-Christophe DUBOIS
2013-05-03 15:20 ` Andreas Färber
2013-05-03 16:04 ` Jean-Christophe DUBOIS
2013-05-03 16:41 ` Andreas Färber
2013-05-04 8:22 ` Jean-Christophe DUBOIS
2013-05-04 8:27 ` Andreas Färber
2013-05-04 8:29 ` Peter Maydell [this message]
2013-05-04 8:38 ` Jean-Christophe DUBOIS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-dLOS8LmoB86uJu3GtwkrBZ7cWjYN1HKrcx=tchhErUQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=jcd@tribudubois.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).