From: Peter Maydell <peter.maydell@linaro.org>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Marcel Apfelbaum" <marcel@redhat.com>,
"Alistair Francis" <alistair23@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/5] Add a valid_cpu_types property
Date: Wed, 20 Dec 2017 00:43:41 +0000 [thread overview]
Message-ID: <CAFEAcA-dvs-E83ZCEk6VAyyQkpghX9oF-d-D62vOKs7kfjPzaw@mail.gmail.com> (raw)
In-Reply-To: <cover.1513729519.git.alistair.francis@xilinx.com>
On 20 December 2017 at 00:27, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> There are numorous QEMU machines that only have a single or a handful of
> valid CPU options. To simplyfy the management of specificying which CPU
> is/isn't valid let's create a property that can be set in the machine
> init. We can then check to see if the user supplied CPU is in that list
> or not.
>
> I have added the valid_cpu_types for some ARM machines only at the
> moment.
>
> Here is what specifying the CPUs looks like now:
>
> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m3" -S
> QEMU 2.10.50 monitor - type 'help' for more information
> (qemu) info cpus
> * CPU #0: thread_id=24175
> (qemu) q
>
> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m4" -S
> QEMU 2.10.50 monitor - type 'help' for more information
> (qemu) q
>
> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m5" -S
> qemu-system-aarch64: unable to find CPU model 'cortex-m5'
>
> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-a9" -S
> qemu-system-aarch64: Invalid CPU type: cortex-a9-arm-cpu
> The valid types are: cortex-m3-arm-cpu, cortex-m4-arm-cpu
Thanks for this; we really should be more strict about
forbidding "won't work" combinations than we have
been in the past.
In the last of these cases, I think that when we
list the invalid CPU type and the valid types
we should use the same names we want the user to
use on the command line, without the "-arm-cpu"
suffixes.
thanks
-- PMM
next prev parent reply other threads:[~2017-12-20 0:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 0:27 [Qemu-devel] [PATCH v4 0/5] Add a valid_cpu_types property Alistair Francis
2017-12-20 0:27 ` [Qemu-devel] [PATCH v4 1/5] netduino2: Specify the valid CPUs Alistair Francis
2017-12-20 0:27 ` [Qemu-devel] [PATCH v4 2/5] bcm2836: Use the Cortex-A7 instead of Cortex-A15 Alistair Francis
2017-12-20 0:27 ` [Qemu-devel] [PATCH v4 3/5] raspi: Specify the valid CPUs Alistair Francis
2017-12-20 0:27 ` [Qemu-devel] [PATCH v4 4/5] xlnx-zcu102: " Alistair Francis
2017-12-20 0:28 ` [Qemu-devel] [PATCH v4 5/5] xilinx_zynq: " Alistair Francis
2017-12-20 0:43 ` Peter Maydell [this message]
2017-12-20 0:55 ` [Qemu-devel] [PATCH v4 0/5] Add a valid_cpu_types property Alistair Francis
2017-12-20 1:03 ` Alistair Francis
2017-12-20 22:06 ` Eduardo Habkost
2017-12-22 18:45 ` Alistair Francis
2017-12-22 19:47 ` Alistair Francis
2017-12-22 21:26 ` Eduardo Habkost
2017-12-28 13:39 ` Igor Mammedov
2017-12-28 14:59 ` Eduardo Habkost
2018-01-10 21:30 ` Alistair Francis
2018-01-10 21:48 ` Eduardo Habkost
2018-01-11 10:25 ` Igor Mammedov
2018-01-11 12:58 ` Eduardo Habkost
2018-02-01 23:21 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-dvs-E83ZCEk6VAyyQkpghX9oF-d-D62vOKs7kfjPzaw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).