From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1atXVL-0001yk-JM
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 05:36:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1atXVK-0008Ea-Ll
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 05:36:03 -0400
Received: from mail-vk0-x22a.google.com ([2607:f8b0:400c:c05::22a]:33142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1atXVK-0008EU-Ic
	for qemu-devel@nongnu.org; Fri, 22 Apr 2016 05:36:02 -0400
Received: by mail-vk0-x22a.google.com with SMTP id n62so129060659vkb.0
	for <qemu-devel@nongnu.org>; Fri, 22 Apr 2016 02:36:02 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1461107270-19234-2-git-send-email-cota@braap.org>
References: <1461107270-19234-1-git-send-email-cota@braap.org>
	<1461107270-19234-2-git-send-email-cota@braap.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 22 Apr 2016 10:35:42 +0100
Message-ID: <CAFEAcA-e2cRVr4yPngMqjc=cnC95WCOGeM72+qPOvgMCw8DenA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 01/11] compiler.h: add QEMU_ALIGNED() to
 enforce struct alignment
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@listserver.greensocs.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Richard Henderson <rth@twiddle.net>, Sergey Fedorov <serge.fdrv@gmail.com>

On 20 April 2016 at 00:07, Emilio G. Cota <cota@braap.org> wrote:
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  include/qemu/compiler.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
> index 8f1cc7b..1978ddc 100644
> --- a/include/qemu/compiler.h
> +++ b/include/qemu/compiler.h
> @@ -41,6 +41,8 @@
>  # define QEMU_PACKED __attribute__((packed))
>  #endif
>
> +#define QEMU_ALIGNED(B) __attribute__((aligned(B)))

A rather trivial thing, but if we have to respin this series
for some other reason could we use a different macro parameter
than 'B', please? I had to re-read the patch carefully before
I realised that (a) it wasn't "aligned(8)" and (b) it wasn't a
typo for "aligned(8)" either...

thanks
-- PMM