From: Peter Maydell <peter.maydell@linaro.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Hannes Reinecke <hare@suse.de>,
qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] qemu in full emulation on win32
Date: Wed, 18 Jul 2012 09:01:16 +0100 [thread overview]
Message-ID: <CAFEAcA-eeEuZaxynPxT15prrFNqFk14QtpZp46Fj4n_fLM3vVQ@mail.gmail.com> (raw)
In-Reply-To: <500657F2.1080703@ozlabs.ru>
On 18 July 2012 07:30, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> 1. The size of the following is 7 bytes on linux and 8 bytes on Windows:
> struct {
> uint32_t hi;
> uint64_t child;
> uint64_t parent;
> uint64_t size;
> } __attribute__((packed)) ranges[];
>
> The structure is used between QEMU and Open Firmware (powerpc bios) so it is important.
I think this struct should use QEMU_PACKED, which will
ensure that it is packed to GCC rules rather than MS
rules.
We also seem to have let a pile of new uses of attribute((packed))
slip in in hw/mfi.h. Those are probably bugs too.
-- PMM
next prev parent reply other threads:[~2012-07-18 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 6:30 [Qemu-devel] qemu in full emulation on win32 Alexey Kardashevskiy
2012-07-18 8:01 ` Peter Maydell [this message]
2012-07-18 16:29 ` Stefan Weil
2012-07-18 17:15 ` Peter Maydell
2012-07-18 16:35 ` Stefan Weil
2012-07-19 0:49 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-eeEuZaxynPxT15prrFNqFk14QtpZp46Fj4n_fLM3vVQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=hare@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).