Re: [PATCH] ppc/pnv: generate dtb after machine initialization is complete

[Peter Maydell <peter.maydell@linaro.org>]

On Thu, 26 Mar 2026 at 11:16, Aditya Gupta <adityag@linux.ibm.com> wrote:
> But still the dts we have is different from what we should have at
> pnv_reset. Adding a pnv_dt_create at the end of pnv_reset, as it used to
> be before, gives me a 'bmc' node also in device tree.
>
>         $ diff /tmp/dts.machinedone /tmp/dts.pnvreset
>         16a17,33
>         >       bmc {
>         >
>         >               sensors {
>         >                       #size-cells = <0x00>;
>         >                       #address-cells = <0x01>;
>         >
>         >                       sensor@0 {
>         >                               ipmi-sensor-type = <0x23>;
>         >                               ipmi-entity-instance = <0x01>;
>         >                               ipmi-entity-id = <0x23>;
>         >                               ipmi-sensor-reading-type = <0x6f>;
>         >                               compatible = "ibm,ipmi-sensor";
>         >                               reg = <0x00>;
>         >                       };
>         >               };
>         >       };
>         >
>
> This isn't handled at machine_init_done as 'pnv->bmc' is not set at this
> time
>
> Two ways to fix it:
> 1. Have pnv_dt_create in pnv_reset as well, like previously
> 2. Move the pnv_bmc_find code in pnv_reset to pnv_init
>
> What do you say ?

My feeling would be that the pnv_bmc_find() handling
should move to the machine-init-done notifier. (pnv_init()
would be too early -- the pnv_bmc_find() code is looking
for a device that has been added via the -device command
line option, so it won't be there yet in pnv_init().)

-- PMM