From: Peter Maydell <peter.maydell@linaro.org>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/7] tests/Makefile: Add check-block to make check on Linux
Date: Wed, 31 Dec 2014 08:53:07 +0000 [thread overview]
Message-ID: <CAFEAcA-f-UbCAv26qaCP_d4dmDukyaWfdrG97DU_gYOdCAGWbQ@mail.gmail.com> (raw)
In-Reply-To: <1420000211-6327-7-git-send-email-famz@redhat.com>
On 31 December 2014 at 04:30, Fam Zheng <famz@redhat.com> wrote:
> "make check-block" does nothing on other platforms, but still takes some
> time to enumerate all the tests. So let's only add it for Linux for now.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index e4ddb6a..0968121 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -467,6 +467,9 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
> check-unit: $(patsubst %,check-%, $(check-unit-y))
> check-block: $(patsubst %,check-%, $(check-block-y))
> check: check-qapi-schema check-unit check-qtest
> +ifeq ($(shell uname -s),"Linux")
You can just use
ifeq ($(CONFIG_LINUX), y)
here, since configure has already identified the host.
thanks
-- PMM
next prev parent reply other threads:[~2014-12-31 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 4:30 [Qemu-devel] [PATCH v3 0/7] tests: Add check-block to "make check" Fam Zheng
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 1/7] .gitignore: Ignore generated "common.env" Fam Zheng
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 2/7] qemu-iotests: Remove 091 from quick group Fam Zheng
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 3/7] qemu-iotests: Replace "/bin/true" with "true" Fam Zheng
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 4/7] qemu-iotests: Add "_supported_os Linux" to 058 Fam Zheng
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 5/7] qemu-iotests: Speed up make check-block Fam Zheng
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 6/7] tests/Makefile: Add check-block to make check on Linux Fam Zheng
2014-12-31 8:53 ` Peter Maydell [this message]
2014-12-31 4:30 ` [Qemu-devel] [PATCH v3 7/7] qemu-iotests: Add supported os parameter for python tests Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-f-UbCAv26qaCP_d4dmDukyaWfdrG97DU_gYOdCAGWbQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).