From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53999)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y6F25-0008DH-DC
	for qemu-devel@nongnu.org; Wed, 31 Dec 2014 03:53:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y6F20-00084j-FI
	for qemu-devel@nongnu.org; Wed, 31 Dec 2014 03:53:33 -0500
Received: from mail-la0-f53.google.com ([209.85.215.53]:46297)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y6F20-00084S-8P
	for qemu-devel@nongnu.org; Wed, 31 Dec 2014 03:53:28 -0500
Received: by mail-la0-f53.google.com with SMTP id gm9so13287526lab.40
	for <qemu-devel@nongnu.org>; Wed, 31 Dec 2014 00:53:27 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1420000211-6327-7-git-send-email-famz@redhat.com>
References: <1420000211-6327-1-git-send-email-famz@redhat.com>
	<1420000211-6327-7-git-send-email-famz@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 31 Dec 2014 08:53:07 +0000
Message-ID: <CAFEAcA-f-UbCAv26qaCP_d4dmDukyaWfdrG97DU_gYOdCAGWbQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 6/7] tests/Makefile: Add check-block to
	make check on Linux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>

On 31 December 2014 at 04:30, Fam Zheng <famz@redhat.com> wrote:
> "make check-block" does nothing on other platforms, but still takes some
> time to enumerate all the tests. So let's only add it for Linux for now.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index e4ddb6a..0968121 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -467,6 +467,9 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
>  check-unit: $(patsubst %,check-%, $(check-unit-y))
>  check-block: $(patsubst %,check-%, $(check-block-y))
>  check: check-qapi-schema check-unit check-qtest
> +ifeq ($(shell uname -s),"Linux")

You can just use
ifeq ($(CONFIG_LINUX), y)
here, since configure has already identified the host.

thanks
-- PMM