From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: Fam Zheng <famz@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
QEMU Developers <qemu-devel@nongnu.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Makefile: Fix "make clean"
Date: Mon, 17 Mar 2014 11:56:48 +0000 [thread overview]
Message-ID: <CAFEAcA-fWLG_Rd8AJMf558+UkUff9JC0HgQaJW2sG8hEtSMPfA@mail.gmail.com> (raw)
In-Reply-To: <532692FA.1090206@weilnetz.de>
On 17 March 2014 06:15, Stefan Weil <sw@weilnetz.de> wrote:
> Am 17.03.2014 02:35, schrieb Fam Zheng:
>> This fixes a dangerous bug: "make clean" after "make distclean" will
>> delete every single file including those under .git, if you do in-tree
>> build!
>>
>> Rationale: A first "make distclean" will unset $(DSOSUF), a following
>> "make distclean" or "make clean" will find all the files and delete it.
>>
>> Fix it by explicitly typing the file extensions here, and combine
>> multiple find invocations into one.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Hello Peter,
>
> this is a bugfix which fixes a potential danger for a developer's
> working directory, so I think it should be fixed directly (not via
> qemu-trivial).
Agreed; applied to master, thanks.
-- PMM
prev parent reply other threads:[~2014-03-17 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 1:35 [Qemu-devel] [PATCH v2] Makefile: Fix "make clean" Fam Zheng
2014-03-17 6:15 ` Stefan Weil
2014-03-17 11:56 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-fWLG_Rd8AJMf558+UkUff9JC0HgQaJW2sG8hEtSMPfA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=famz@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).