From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39014)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WPWAN-0004yv-HQ
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 07:57:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WPWAI-0001EF-Lt
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 07:57:15 -0400
Received: from mail-lb0-f180.google.com ([209.85.217.180]:40273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WPWAI-0001Dp-FG
	for qemu-devel@nongnu.org; Mon, 17 Mar 2014 07:57:10 -0400
Received: by mail-lb0-f180.google.com with SMTP id 10so3521786lbg.39
	for <qemu-devel@nongnu.org>; Mon, 17 Mar 2014 04:57:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <532692FA.1090206@weilnetz.de>
References: <1395020122-4957-1-git-send-email-famz@redhat.com>
	<532692FA.1090206@weilnetz.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 17 Mar 2014 11:56:48 +0000
Message-ID: <CAFEAcA-fWLG_Rd8AJMf558+UkUff9JC0HgQaJW2sG8hEtSMPfA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2] Makefile: Fix "make clean"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Fam Zheng <famz@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, QEMU Developers <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 17 March 2014 06:15, Stefan Weil <sw@weilnetz.de> wrote:
> Am 17.03.2014 02:35, schrieb Fam Zheng:
>> This fixes a dangerous bug: "make clean" after "make distclean" will
>> delete every single file including those under .git, if you do in-tree
>> build!
>>
>> Rationale: A first "make distclean" will unset $(DSOSUF), a following
>> "make distclean" or "make clean" will find all the files and delete it.
>>
>> Fix it by explicitly typing the file extensions here, and combine
>> multiple find invocations into one.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>

> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Hello Peter,
>
> this is a bugfix which fixes a potential danger for a developer's
> working directory, so I think it should be fixed directly (not via
> qemu-trivial).

Agreed; applied to master, thanks.

-- PMM