From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48370)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZNhLP-0003qy-LV
	for qemu-devel@nongnu.org; Fri, 07 Aug 2015 09:05:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZNhLL-0008RU-Lq
	for qemu-devel@nongnu.org; Fri, 07 Aug 2015 09:05:55 -0400
Received: from mail-vk0-f53.google.com ([209.85.213.53]:36359)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZNhLL-0008Qb-Hi
	for qemu-devel@nongnu.org; Fri, 07 Aug 2015 09:05:51 -0400
Received: by vkci6 with SMTP id i6so38327715vkc.3
	for <qemu-devel@nongnu.org>; Fri, 07 Aug 2015 06:05:51 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <d57acc7898cc4bbc9bef8d4e20035a15288ac156.1437080501.git.jcd@tribudubois.net>
References: <cover.1437080501.git.jcd@tribudubois.net>
	<d57acc7898cc4bbc9bef8d4e20035a15288ac156.1437080501.git.jcd@tribudubois.net>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 7 Aug 2015 14:05:31 +0100
Message-ID: <CAFEAcA-fpftt1r0LLDBpnJNMXdvmKUTUThWxVfOqagijQqVpwQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v13 18/19] i.MX: Add qtest support for I2C
 device emulator.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 16 July 2015 at 22:21, Jean-Christophe Dubois <jcd@tribudubois.net> wrote:
> This is using a ds1338 RTC chip on the I2C bus. This RTC chip is
> not present on the real 3DS PDK board.
>
> Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>

'make check' doesn't pass with this patch, because it tries to start
an "imx25_3ds" machine, which doesn't exist.

> +#define bcd2bin(x)        (((x) & 0x0f) + ((x) >> 4) * 10)

Why not just make this an inline function?

> +static void send_and_receive(void)
> +{
> +    uint8_t cmd[1];
> +    uint8_t resp[7];
> +    time_t now = time(NULL);
> +    struct tm *tm_ptr = gmtime(&now);
> +
> +    /* reset the index in the RTC memory */
> +    cmd[0] = 0;
> +    i2c_send(i2c, addr, cmd, 1);
> +
> +    /* retrieve the date */
> +    i2c_recv(i2c, addr, resp, 7);
> +
> +    /* check retreived time againt local time */

"retrieved"

-- PMM