From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TsbtY-0001IK-3t
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:19:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TsbtT-0000vI-9l
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:19:20 -0500
Received: from mail-la0-f41.google.com ([209.85.215.41]:47229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TsbtT-0000vE-27
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:19:15 -0500
Received: by mail-la0-f41.google.com with SMTP id em20so674172lab.28
	for <qemu-devel@nongnu.org>; Tue, 08 Jan 2013 08:19:14 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1357584074-10852-9-git-send-email-fred.konrad@greensocs.com>
References: <1357584074-10852-1-git-send-email-fred.konrad@greensocs.com>
	<1357584074-10852-9-git-send-email-fred.konrad@greensocs.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 8 Jan 2013 16:18:53 +0000
Message-ID: <CAFEAcA-fs08_OCBGCiBoR0sHL7SD-Y+6hw-BTKGuCrZFfBB4Bg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock
	structure.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: kwolf@redhat.com, aliguori@us.ibm.com, e.voevodin@samsung.com, mst@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, amit.shah@redhat.com, aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de

On 7 January 2013 18:40,  <fred.konrad@greensocs.com> wrote:
> virtio-blk : show VirtIOBlock structure.

If this survives as a separate patch then this should read
"virtio-blk: make VirtIOBlock structure public"

> As we discuss with anthony and andreas, this structure must be showed to avoid
> two memory allocations for virtio-blk-x.

I don't really like chatty references to mailing list discussions in
commit messages; commit messages should just confidently
say what/why they're making the change. You can always put
in remarks below the '---' line if you want to remind reviewers of
earlier discussion. Similarly, you don't need to say "must be
committed after patches X and Y" in the commit message proper --
as a git commit the order is inherent.

-- PMM