From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VowbF-0005ve-LM
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 09:41:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VowbA-0002R3-Qu
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 09:41:49 -0500
Received: from mail-pb0-f44.google.com ([209.85.160.44]:36994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VowbA-0002Qu-Ko
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 09:41:44 -0500
Received: by mail-pb0-f44.google.com with SMTP id rq2so1193183pbb.3
	for <qemu-devel@nongnu.org>; Fri, 06 Dec 2013 06:41:43 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <303b8e9c013e9c5a74f9441d500102d70a4cf493.1386053678.git.peter.crosthwaite@xilinx.com>
References: <cover.1386053678.git.peter.crosthwaite@xilinx.com>
	<303b8e9c013e9c5a74f9441d500102d70a4cf493.1386053678.git.peter.crosthwaite@xilinx.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 6 Dec 2013 14:41:23 +0000
Message-ID: <CAFEAcA-gH+rx4QCyMAt35xRKB5NoMhGMRDvjj-=N58+RLySPAQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH arm-devs v3 4/9] target-arm/cpu: Convert
	reset CBAR to a property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Mark Langsdorf <mark.langsdorf@calxeda.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>

On 3 December 2013 07:01, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> The reset Value of the CP15 CBAR is a vendor (machine) configurable

no need to capitalize "value" here.

> property. If ARM_FEATURE_CBAR is set, add it as a property at
> post_init time.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

PS: this patch has conflicts (largely textual, easy enough to resolve)
with the patches in my v7-mach-virt series. If you do a respin of this
before I get round to the next target-arm pullreq (likely to be early next
week) it might be simplest to base that respin on top of the target-arm.next
branch (in git://git.linaro.org/people/pmaydell/qemu-arm.git ; nb the
server is down for maintanance this Sunday). That would save me
the effort of fixing up the conflicts ;-)

thanks
-- PMM