qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org, Emre Ersin <emre.ersin@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Set default locale C
Date: Sat, 24 Mar 2012 12:44:03 +0000	[thread overview]
Message-ID: <CAFEAcA-hYYYCQH1QigJ4A77d9qJUz8sM7a53QXfURuL1P8bGeQ@mail.gmail.com> (raw)
In-Reply-To: <1332533128-24331-1-git-send-email-sw@weilnetz.de>

On 23 March 2012 20:05, Stefan Weil <sw@weilnetz.de> wrote:
> +# Set default locale for commands like tr and others.
> +LANG=C
> +LC_ALL=C
> +LC_CTYPE=C

You don't export these, which leads to an obscure corner case:
if the user has no LANG variable set in their environment when
they run make then we will set LANG=C in the top level makefile
but it will not be set in a sub-makefile. Since the default
locale is the same as the C locale this doesn't make any
practical difference, but it's a little odd.

(Make automatically exports variables to submakes if they had
some value in its environment when it was started, but not if
they were only set in the makefile.)

Also, do we need to set these in configure too?

-- PMM

  reply	other threads:[~2012-03-24 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23  8:50 [Qemu-devel] [Bug 962880] [NEW] having a tr_TR.UTF-8 locale creates problems during compile Emre Ersin
2012-03-23 20:05 ` [Qemu-devel] [PATCH] Makefile: Set default locale C Stefan Weil
2012-03-24 12:44   ` Peter Maydell [this message]
2012-03-24 16:11     ` Emre Ersin
2012-03-24 17:56       ` Stefan Weil
2012-03-23 20:12 ` [Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile Stefan Weil
2012-03-25 19:15 ` Stefan Weil
2012-03-31 18:28 ` Stefan Weil
2012-09-07 14:35 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-hYYYCQH1QigJ4A77d9qJUz8sM7a53QXfURuL1P8bGeQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=emre.ersin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).