From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBQKG-0006Wg-AD for qemu-devel@nongnu.org; Sat, 24 Mar 2012 08:44:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBQKE-0004ag-Db for qemu-devel@nongnu.org; Sat, 24 Mar 2012 08:44:07 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:48536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBQKE-0004aA-9f for qemu-devel@nongnu.org; Sat, 24 Mar 2012 08:44:06 -0400 Received: by iafj26 with SMTP id j26so6941050iaf.4 for ; Sat, 24 Mar 2012 05:44:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1332533128-24331-1-git-send-email-sw@weilnetz.de> References: <20120323085010.26047.31273.malonedeb@chaenomeles.canonical.com> <1332533128-24331-1-git-send-email-sw@weilnetz.de> Date: Sat, 24 Mar 2012 12:44:03 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] Makefile: Set default locale C List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org, Emre Ersin On 23 March 2012 20:05, Stefan Weil wrote: > +# Set default locale for commands like tr and others. > +LANG=C > +LC_ALL=C > +LC_CTYPE=C You don't export these, which leads to an obscure corner case: if the user has no LANG variable set in their environment when they run make then we will set LANG=C in the top level makefile but it will not be set in a sub-makefile. Since the default locale is the same as the C locale this doesn't make any practical difference, but it's a little odd. (Make automatically exports variables to submakes if they had some value in its environment when it was started, but not if they were only set in the makefile.) Also, do we need to set these in configure too? -- PMM