From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1b5umK-0004Rj-3S
	for qemu-devel@nongnu.org; Thu, 26 May 2016 08:52:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1b5umI-0006H5-0u
	for qemu-devel@nongnu.org; Thu, 26 May 2016 08:52:43 -0400
Received: from mail-vk0-x232.google.com ([2607:f8b0:400c:c05::232]:36784)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1b5umG-0006Gh-V3
	for qemu-devel@nongnu.org; Thu, 26 May 2016 08:52:41 -0400
Received: by mail-vk0-x232.google.com with SMTP id k1so45452889vka.3
	for <qemu-devel@nongnu.org>; Thu, 26 May 2016 05:52:40 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5745D4B7.40705@gmail.com>
References: <1463404380-29302-1-git-send-email-sergey.fedorov@linaro.org>
	<53a44acc-2a09-c321-a649-85e659bbc1e6@twiddle.net>
	<5739DAE2.3010802@gmail.com> <5745D4B7.40705@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 26 May 2016 13:52:20 +0100
Message-ID: <CAFEAcA-iAGNeaU-vTxoYsK8-0RFCHbRnTMwPXZJY43rU0uL=HA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning
 page
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>, Sergey Fedorov <sergey.fedorov@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 25 May 2016 at 17:37, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
> On 16/05/16 17:36, Sergey Fedorov wrote:
>> On 16/05/16 16:49, Richard Henderson wrote:
>>> On 05/16/2016 06:13 AM, Sergey Fedorov wrote:
>>>> It is not safe to make a direct jump to a TB spanning two pages in
>>>> system emulation because the mapping for the second page can get changed
>>>> but we don't take care of direct jumps in this case.
>>> We don't?  I'm pretty sure that we do...
>> What we just do is flushing the CPU virtual address cache, see for
>> tlb_flush() etc.
>
> Ping. This patch fixed a bug discussed in this thread:
> http://thread.gmane.org/gmane.comp.emulators.qemu/411648

Applied to master, thanks.

-- PMM