From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aXmds-0002rM-Bt
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:18:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aXmdr-0006PK-Gi
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:18:56 -0500
Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:33905)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aXmdr-0006PA-8h
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:18:55 -0500
Received: by mail-vk0-x235.google.com with SMTP id e185so123766165vkb.1
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 01:18:55 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1456110933-5457-10-git-send-email-zxq_yx_007@163.com>
References: <1456110933-5457-1-git-send-email-zxq_yx_007@163.com>
	<1456110933-5457-10-git-send-email-zxq_yx_007@163.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 22 Feb 2016 09:18:35 +0000
Message-ID: <CAFEAcA-iTcWTX5eVpe9NWb5MqYVcxUajRCnzQVFY=raBq-an4w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, QEMU Developers <qemu-devel@nongnu.org>, Michael Walle <michael@walle.cc>, qemu-arm <qemu-arm@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Maksim Kozlov <m.kozlov@samsung.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>

On 22 February 2016 at 03:15, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> Move majority of old SysBus init's work the into instance_init.
>
> Note:
> musb_init must be called in SysBus's init, otherwise it will
> break "make check" with error message as follows:
>
> qom/object.c:1576:object_get_canonical_path_component: assertion failed: (obj->parent != NULL)
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  hw/timer/tusb6010.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)

Devices should either be instance_init + realize, or
sysbus-init. This patch would make this device be a mix
of both. You should just drop this patch until musb has
been properly QOMified.

thanks
-- PMM