From: Peter Maydell <peter.maydell@linaro.org>
To: Dylan Jhong <dylan@andestech.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH] hw/char/serial: Support serial_mm_init() with wakeup event.
Date: Wed, 23 Mar 2022 09:37:10 +0000 [thread overview]
Message-ID: <CAFEAcA-iYmzGg4aqW6qPhiGhbWtp+kY06pGsPHgDiOyyn6YpUQ@mail.gmail.com> (raw)
In-Reply-To: <20220323091637.5609-1-dylan@andestech.com>
On Wed, 23 Mar 2022 at 09:20, Dylan Jhong <dylan@andestech.com> wrote:
>
> Although the "wakeup" parameter is declared in SerialState,
> but there is no function actually setting it up.
> Support "wakeup" as parameter in serial_mm_init().
This patch seems to provide a new argument which every
caller passes the same value for, unless I missed one
somewhere. What's the reason for this change?
thanks
-- PMM
next prev parent reply other threads:[~2022-03-23 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:16 [PATCH] hw/char/serial: Support serial_mm_init() with wakeup event Dylan Jhong
2022-03-23 9:37 ` Peter Maydell [this message]
[not found] ` <YjwUXU0+0xSCjfpN@atcsi01>
2022-03-24 10:00 ` Dylan Jhong
2022-03-24 12:51 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-iYmzGg4aqW6qPhiGhbWtp+kY06pGsPHgDiOyyn6YpUQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=dylan@andestech.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).