From: Peter Maydell <peter.maydell@linaro.org>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Auger Eric <eric.auger@redhat.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR
Date: Fri, 25 May 2018 10:00:44 +0100 [thread overview]
Message-ID: <CAFEAcA-k4Yz3bfXWsB1fGGoTMV_A016nasyagKrO9TuSObyW6A@mail.gmail.com> (raw)
In-Reply-To: <5B07CC79.1070905@huawei.com>
On 25 May 2018 at 09:42, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> On 2018/5/24 22:56, Peter Maydell wrote:
>> We can fix the gicd_ipriority[] case simply by adding
>> bmp = GIC_INTERNAL;
>> before the assignment to 'field' in both kvm_dist_get_priority()
>> and kvm_dist_put_priority(). This doesn't affect migration
>> compatibility. We should do this separately from fixing the
>> other bitmaps, because it's simpler.
>>
> If we do bmp += GIC_INTERNAL, we should also add this to offset,
> otherwise we will put the SGI/PPIs data to SPIs, right?
Yes. This code seems remarkably hard to get right, I think
because we effectively have three different things indexing
through the loop -- irq, field, offset -- and they're all
independently set to starting values in different places.
thanks
-- PMM
next prev parent reply other threads:[~2018-05-25 9:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 3:53 [Qemu-devel] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly Shannon Zhao
2018-05-23 3:53 ` [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR Shannon Zhao
2018-05-24 9:04 ` Auger Eric
2018-05-24 9:20 ` Shannon Zhao
2018-05-24 12:10 ` Auger Eric
2018-05-24 13:14 ` Peter Maydell
2018-05-24 13:59 ` Auger Eric
2018-05-24 14:16 ` Peter Maydell
2018-05-24 14:40 ` Auger Eric
2018-05-24 14:56 ` Peter Maydell
2018-05-24 14:58 ` Peter Maydell
2018-05-24 15:09 ` Auger Eric
2018-05-25 8:42 ` Shannon Zhao
2018-05-25 9:00 ` Peter Maydell [this message]
2018-05-24 13:11 ` Peter Maydell
2018-05-25 9:15 ` Shannon Zhao
2018-05-24 12:38 ` [Qemu-devel] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-k4Yz3bfXWsB1fGGoTMV_A016nasyagKrO9TuSObyW6A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=eric.auger@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).