From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4869BC77B7F for ; Fri, 5 May 2023 12:23:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puuSc-0005M5-3k; Fri, 05 May 2023 08:22:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puuSU-0005KZ-HU for qemu-devel@nongnu.org; Fri, 05 May 2023 08:22:46 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puuSF-0000iR-Nc for qemu-devel@nongnu.org; Fri, 05 May 2023 08:22:46 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-50bd875398dso2576680a12.1 for ; Fri, 05 May 2023 05:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683289350; x=1685881350; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qPCyVI9kr62LNVgR4MbqahLwPDo/qYs+kZjMEDVEdgs=; b=c3/VtSjrE8eDpQLHbaU8mXFdQUcrP2PAssHxyJZRDf+eEafZC4C2BGhqJmtrRZx/Go Qim6W1WVIdSD9dQ3lfl/IqXocrhAHwRLX6q3BJeYref1EJ+gMQ0lnLhKdMpvHvm2Xuim GLMTsU8DK7zeavvsM1cXrMvMXQCN9UaP4B7FBCXzFnqEWNHDI+HXzuJYe4v+JkMo9rMH UUpQcdQua2xCzssBPVLA0DJBHHDgWnNzM4Oj7s71u0kOZNXtZFfht6GS8ufCZqCG3Slk 1DXbLZjDlIVrWHQA81QSRT8RA9MfWZaWfEEegnEsKXbekjdP1ElYPbYVMZ2Osnb7b9IF XTVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683289350; x=1685881350; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qPCyVI9kr62LNVgR4MbqahLwPDo/qYs+kZjMEDVEdgs=; b=HJcQn3VU/jp9Hrb1Qu8L6z+4I92tN8aFTeAn3X+yCKsP/MetVacKV2aXlbeXNwyuWd i66EzpTumuj3EC8Fuuu5GCYqKThY+3KJFUXVJjzvAh/P7oE86F4QV7dzjB1G9q8ZfAth hUQFOgtqSkquekoY+ZlRo6HxPQIjHfnE5nI15MOSyCY6NZLiEWBfnlO3H6/FnzJAWiLE N/URR5itKGhMGChrRyxjSKnlk7KxtCHKq2xxWN0PWi4VYWOo7nqzGPWcEa/e9N9COiO7 NrtEJPk0G3mMqg75mCKA8erCClj69g227rO0Fq8wiT6LcR8Sh3JqTBTAmqKfm4WhheJY 69mw== X-Gm-Message-State: AC+VfDybhIxoGMlXPzz98n3NQ7lPUEBAMHozJi4LxN+Pnie1j34+20c8 U05YYcSur8S2+lKrJ+1pweOx3705u50aCvnqICGBvnkHWJESg0Uz X-Google-Smtp-Source: ACHHUZ7LBOByzBwKvAALCVKb2H6FJrXHwfe1n8dGGTzOXfudUqHClVQTjJnZCiMZJUxAr874wJXprR45Tva5szrHsyw= X-Received: by 2002:a05:6402:2044:b0:50b:c77e:b071 with SMTP id bc4-20020a056402204400b0050bc77eb071mr1316111edb.18.1683289349953; Fri, 05 May 2023 05:22:29 -0700 (PDT) MIME-Version: 1.0 References: <20230503070656.1746170-1-richard.henderson@linaro.org> <20230503070656.1746170-33-richard.henderson@linaro.org> In-Reply-To: <20230503070656.1746170-33-richard.henderson@linaro.org> From: Peter Maydell Date: Fri, 5 May 2023 13:22:19 +0100 Message-ID: Subject: Re: [PATCH v4 32/57] tcg/sparc64: Rename tcg_out_movi_imm32 to tcg_out_movi_u32 To: Richard Henderson Cc: qemu-devel@nongnu.org, git@xen0n.name, gaosong@loongson.cn, philmd@linaro.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 3 May 2023 at 08:15, Richard Henderson wrote: > > Emphasize that the constant is unsigned. > > Signed-off-by: Richard Henderson > --- > tcg/sparc64/tcg-target.c.inc | 24 ++++++++++-------------- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc > index 2e6127d506..e244209890 100644 > --- a/tcg/sparc64/tcg-target.c.inc > +++ b/tcg/sparc64/tcg-target.c.inc > @@ -399,22 +399,18 @@ static void tcg_out_sethi(TCGContext *s, TCGReg ret, uint32_t arg) > tcg_out32(s, SETHI | INSN_RD(ret) | ((arg & 0xfffffc00) >> 10)); > } > > +/* A 13-bit constant sign-extended to 64 bits. */ This should have been in the previous patch, I think ? > static void tcg_out_movi_s13(TCGContext *s, TCGReg ret, int32_t arg) > { > tcg_out_arithi(s, ret, TCG_REG_G0, arg, ARITH_OR); > } > > -static void tcg_out_movi_imm32(TCGContext *s, TCGReg ret, int32_t arg) > +/* A 32-bit constant zero-extended to 64 bits. */ > +static void tcg_out_movi_u32(TCGContext *s, TCGReg ret, uint32_t arg) > { > - if (check_fit_i32(arg, 13)) { > - /* A 13-bit constant sign-extended to 64-bits. */ > - tcg_out_movi_s13(s, ret, arg); > - } else { > - /* A 32-bit constant zero-extended to 64 bits. */ > - tcg_out_sethi(s, ret, arg); > - if (arg & 0x3ff) { > - tcg_out_arithi(s, ret, ret, arg & 0x3ff, ARITH_OR); > - } > + tcg_out_sethi(s, ret, arg); > + if (arg & 0x3ff) { > + tcg_out_arithi(s, ret, ret, arg & 0x3ff, ARITH_OR); > } > } More code changes in a patch that says it's a rename-only. -- PMM