From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2F97C77B7C for ; Fri, 5 May 2023 09:37:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1purrn-00034V-HZ; Fri, 05 May 2023 05:36:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1purrl-0002uh-BZ for qemu-devel@nongnu.org; Fri, 05 May 2023 05:36:41 -0400 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1purri-0003c6-T8 for qemu-devel@nongnu.org; Fri, 05 May 2023 05:36:41 -0400 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bc4b88998so2627631a12.3 for ; Fri, 05 May 2023 02:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683279397; x=1685871397; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rOxAmCxmq4mUmQUBKqSuiGDnmChZNo7gJ0Dlt2ph/T4=; b=IxMAP7a/YsZVoKDoPthH7twSLdBtu+z1Mg1s/uv1lQwYGACb9QDrGo0qr8lvrxAAlU BeHoLL5rfx3JhmTAjJM8vw4TVYNtlw7dUKA8fBlWoOaS/rgo6w/hR6H/6k8fHbhqMpxc 7uLvBeS1RoMtcL4QBT8JYYWoauAM/M+XOOSj9mOKpIV+NHPPSIxp8lyBE3ktf9QDB5in CEx+TiNLq2Q2s3aOAGyQlEwoRd7Qgljx+lxYOy4f/Ee/dwKG2iYQPxEkaVLRc78PcDej OfzRSYV/BL+fhYeNXiC61Av8DSKbG+fvu7isyoj4pqsd9vgLiLm/MX0Uztf+aUa2ybAV YhCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683279397; x=1685871397; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rOxAmCxmq4mUmQUBKqSuiGDnmChZNo7gJ0Dlt2ph/T4=; b=R+mtTHYxL5zri+kc8+lluuyxt15g9MUg60/V6zltwgHdnLEiTLy/RAuIrRXLSuvkpb t6BU5h1xuchtPf2C/19YjFEpiLHD3yQ24ytVyDL4zDrdfIyW+rlX1r8fEc2bUQgAV8V5 kPV/YAUyymyfVbXvi8qVeOyr7MZOmt/00mdtBfzh9KqTJXMID8VX6cuxF7Ol9vUP/g7X 2ri+Aebo0+HX0fiTQ92CIld1Gjl5ghv+Pp3xF/ChauzEW2yUlopwmUpW9eieOv0ZUNdl KRmDCR0flf7CaPJLVpLjcG7bUFXTD7E4q4EvQY0vjEdQ9zI4vJhLvPw6eP+0Ve+BRVll 3R/Q== X-Gm-Message-State: AC+VfDzYvqv6WssDwm34AdFYXbuGhTGSG4GzqAuZNd2UJUIYpn++gTgf avT4OJKSFZzz/TDYSJnWt3e4LDtfCOko3V4Gt2QQgw== X-Google-Smtp-Source: ACHHUZ5pkR8UwmRh6C3wTmfx21nSHayjmf2zWPuhZUNzyhoVefBnfSPD81hSuQYDHmCX3BahFPuJq8/4tUvY7uFEu2g= X-Received: by 2002:aa7:ce18:0:b0:50b:febd:3cde with SMTP id d24-20020aa7ce18000000b0050bfebd3cdemr649377edv.42.1683279397303; Fri, 05 May 2023 02:36:37 -0700 (PDT) MIME-Version: 1.0 References: <20230503070656.1746170-1-richard.henderson@linaro.org> <20230503070656.1746170-10-richard.henderson@linaro.org> In-Reply-To: <20230503070656.1746170-10-richard.henderson@linaro.org> From: Peter Maydell Date: Fri, 5 May 2023 10:36:26 +0100 Message-ID: Subject: Re: [PATCH v4 09/57] tcg: Unify helper_{be,le}_{ld,st}* To: Richard Henderson Cc: qemu-devel@nongnu.org, git@xen0n.name, gaosong@loongson.cn, philmd@linaro.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 3 May 2023 at 08:15, Richard Henderson wrote: > > With the current structure of cputlb.c, there is no difference > between the little-endian and big-endian entry points, aside > from the assert. Unify the pairs of functions. > > Hoist the qemu_{ld,st}_helpers arrays to tcg.c. > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM