From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49394)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZWnxh-0001MO-G8
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:59:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZWnxb-0003Cs-Nm
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:59:05 -0400
Received: from mail-vk0-f46.google.com ([209.85.213.46]:35390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZWnxb-0003Co-CB
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:58:59 -0400
Received: by vkaw128 with SMTP id w128so59310867vka.2
	for <qemu-devel@nongnu.org>; Tue, 01 Sep 2015 08:58:59 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1440615870-9518-3-git-send-email-wei@redhat.com>
References: <1440615870-9518-1-git-send-email-wei@redhat.com>
	<1440615870-9518-3-git-send-email-wei@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 1 Sep 2015 16:58:39 +0100
Message-ID: <CAFEAcA-nOBEydD+=QJFO1CtU2s-8M0JksuN74pphU_CExpWT2Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [ARM SMBIOS V5 PATCH 2/2] smbios: implement smbios
	support for mach-virt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wei Huang <wei@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Gabriel L. Somlo" <somlo@cmu.edu>, Shannon Zhao <zhaoshenglong@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Leif Lindholm <leif.lindholm@linaro.org>, Roy Franz <roy.franz@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, jdelvare@suse.de, Richard Henderson <rth@twiddle.net>

On 26 August 2015 at 20:04, Wei Huang <wei@redhat.com> wrote:
> This patch generates smbios tables for ARM mach-virt. Also add
> CONFIG_SMBIOS=y for ARM default config.
>
> Acked-by: Gabriel Somlo <somlo@cmu.edu>
> Tested-by: Gabriel Somlo <somlo@cmu.edu>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
> Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Wei Huang <wei@redhat.com>

> +static void virt_build_smbios(VirtGuestInfo *guest_info)
> +{
> +    FWCfgState *fw_cfg = guest_info->fw_cfg;
> +    uint8_t *smbios_tables, *smbios_anchor;
> +    size_t smbios_tables_len, smbios_anchor_len;
> +
> +    if (!fw_cfg)
> +        return;

Missing braces for if (). You can catch this sort of thing
yourself by running scripts/checkpatch.pl on your patches.

In this case this looks like the only issue with this patchset,
so I'll fix it when I put it into target-arm.next.

thanks
-- PMM