* [Qemu-devel] [PATCH for-2.0 v1 1/1] timer: cadence_ttc: Fix match register write logic
@ 2014-04-01 4:31 Peter Crosthwaite
2014-04-01 17:12 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Peter Crosthwaite @ 2014-04-01 4:31 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
This switch logic should not fall through. Fix.
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
Spotted by Coverity (via PMM)
hw/timer/cadence_ttc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/timer/cadence_ttc.c b/hw/timer/cadence_ttc.c
index a279bce..28cb328 100644
--- a/hw/timer/cadence_ttc.c
+++ b/hw/timer/cadence_ttc.c
@@ -346,11 +346,13 @@ static void cadence_ttc_write(void *opaque, hwaddr offset,
case 0x34:
case 0x38:
s->reg_match[0] = value & 0xffff;
+ break;
case 0x3c: /* match register */
case 0x40:
case 0x44:
s->reg_match[1] = value & 0xffff;
+ break;
case 0x48: /* match register */
case 0x4c:
--
1.9.1.1.gbb9f595
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.0 v1 1/1] timer: cadence_ttc: Fix match register write logic
2014-04-01 4:31 [Qemu-devel] [PATCH for-2.0 v1 1/1] timer: cadence_ttc: Fix match register write logic Peter Crosthwaite
@ 2014-04-01 17:12 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2014-04-01 17:12 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: QEMU Developers
On 1 April 2014 05:31, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> This switch logic should not fall through. Fix.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> Spotted by Coverity (via PMM)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
I'm not planning to put this into 2.0 at this stage,
unless you think it's important to do so.
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-01 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 4:31 [Qemu-devel] [PATCH for-2.0 v1 1/1] timer: cadence_ttc: Fix match register write logic Peter Crosthwaite
2014-04-01 17:12 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).