From: Peter Maydell <peter.maydell@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to sun4m.h
Date: Wed, 25 Oct 2017 11:44:58 +0100 [thread overview]
Message-ID: <CAFEAcA-o2ZRHgdCL-fO9xy2Y1-DmMGrA3hDSx_PP99w3ygH7CQ@mail.gmail.com> (raw)
In-Reply-To: <1508006342-5304-10-git-send-email-mark.cave-ayland@ilande.co.uk>
On 14 October 2017 at 19:38, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> This enables them to be used outside of lance.c.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> CC: Jason Wang <jasowang@redhat.com>
> ---
> hw/net/lance.c | 9 ---------
> include/hw/sparc/sun4m.h | 13 +++++++++++++
> 2 files changed, 13 insertions(+), 9 deletions(-)
I would suggest creating a new header file for this device,
include/hw/net/lance.h, rather than stuffing it into the sun4m.h header.
(That kind of header is a bit of a legacy from when we had
ad-hoc header organization, so in general we'd expect things to
go out of it rather than be added to it...)
thanks
-- PMM
next prev parent reply other threads:[~2017-10-25 10:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 18:38 [Qemu-devel] [PATCHv3 00/13] sun4m: sparc32_dma tidy-ups Mark Cave-Ayland
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 01/13] sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE Mark Cave-Ayland
2017-10-19 4:26 ` Philippe Mathieu-Daudé
2017-10-20 12:39 ` Mark Cave-Ayland
2017-10-27 16:25 ` Philippe Mathieu-Daudé
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices Mark Cave-Ayland
2017-10-19 4:33 ` Philippe Mathieu-Daudé
2017-10-20 12:41 ` Mark Cave-Ayland
2017-10-27 16:26 ` Philippe Mathieu-Daudé
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 03/13] sparc32_dma: move type declarations from sparc32_dma.c to sparc32_dma.h Mark Cave-Ayland
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 04/13] sun4m: move DMA device wiring from sparc32_dma_init() to sun4m_hw_init() Mark Cave-Ayland
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 05/13] sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to sun4m.h Mark Cave-Ayland
2017-10-19 4:37 ` Philippe Mathieu-Daudé
2017-10-20 12:47 ` Mark Cave-Ayland
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 06/13] sparc32_dma: use object link instead of qdev property to pass IOMMU reference Mark Cave-Ayland
2017-10-19 4:38 ` Philippe Mathieu-Daudé
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 07/13] esp: move TYPE_ESP and SysBusESPState from esp.c to esp.h Mark Cave-Ayland
2017-10-25 10:42 ` Peter Maydell
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 08/13] sparc32_dma: make esp device child of espdma device Mark Cave-Ayland
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to sun4m.h Mark Cave-Ayland
2017-10-25 10:44 ` Peter Maydell [this message]
2017-10-14 18:38 ` [Qemu-devel] [PATCHv3 10/13] sparc32_dma: make lance device child of ledma device Mark Cave-Ayland
2017-10-14 18:39 ` [Qemu-devel] [PATCHv3 11/13] sparc32_dma: introduce new SPARC32_DMA type container object Mark Cave-Ayland
2017-10-14 18:39 ` [Qemu-devel] [PATCHv3 12/13] sparc32_dma: remove is_ledma hack and replace with memory region alias Mark Cave-Ayland
2017-10-14 18:39 ` [Qemu-devel] [PATCHv3 13/13] sparc32_dma: add len to esp/le DMA memory tracing Mark Cave-Ayland
2017-10-19 4:45 ` Philippe Mathieu-Daudé
2017-10-14 19:23 ` [Qemu-devel] [PATCHv3 00/13] sun4m: sparc32_dma tidy-ups no-reply
2017-10-15 7:14 ` Mark Cave-Ayland
2017-10-18 9:12 ` Artyom Tarasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-o2ZRHgdCL-fO9xy2Y1-DmMGrA3hDSx_PP99w3ygH7CQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=jasowang@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).