From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Emilio G. Cota" <cota@braap.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: race condition in tests/fp/Makefile
Date: Tue, 7 Jan 2020 17:06:03 +0000 [thread overview]
Message-ID: <CAFEAcA-oNYP+-ej52GniCUoNU1K16Ah3pk0SDQXDqEnz+2SSgQ@mail.gmail.com> (raw)
In-Reply-To: <87imlnjj05.fsf@linaro.org>
On Tue, 7 Jan 2020 at 17:04, Alex Bennée <alex.bennee@linaro.org> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
> > Also, should we change tests/vm to separately invoke
> > 'make' and 'make check' ? I think that doing a single
> > 'make check' is a bit fragile because we don't
> > really test it and there's no rule that says
> > "check depends on all" or similar AFAIK.
>
> OK - although shouldn't our rules be robust enough for this.
Ideally, you might hope that -- but I'm a bit
sceptical that we really correctly express all the
dependencies that every test has on the build having
actually built the things it needs to build...
-- PMM
prev parent reply other threads:[~2020-01-07 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 16:08 race condition in tests/fp/Makefile Peter Maydell
2020-01-07 17:04 ` Alex Bennée
2020-01-07 17:06 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-oNYP+-ej52GniCUoNU1K16Ah3pk0SDQXDqEnz+2SSgQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).