From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19A2C33C9B for ; Tue, 7 Jan 2020 17:09:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFBB82087F for ; Tue, 7 Jan 2020 17:09:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WTx+ol8o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFBB82087F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iosMP-0007zO-Gy for qemu-devel@archiver.kernel.org; Tue, 07 Jan 2020 12:09:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46547) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iosJ6-0002Uv-2c for qemu-devel@nongnu.org; Tue, 07 Jan 2020 12:06:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iosJ5-00070i-5F for qemu-devel@nongnu.org; Tue, 07 Jan 2020 12:06:15 -0500 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:40410) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iosJ5-00070Y-16 for qemu-devel@nongnu.org; Tue, 07 Jan 2020 12:06:15 -0500 Received: by mail-oi1-x231.google.com with SMTP id c77so102261oib.7 for ; Tue, 07 Jan 2020 09:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+QUdzuKCt2vIM6GeENeuSg4pDrygiUIt0KhoCO356dU=; b=WTx+ol8ofJNvqRmmN2HnkQkV0olruesAygXzQTL6r3t6KTo3rr/Lting4bQS9rN4mH 0uGB6DjpPnhKfXTDH1gjfRf31zdCD5kaI2P3tjhpsQMIKV5QmVoBzfb973lVs7xTSGcd 3Y7b2gU3AgkWLakxivWQWeIe4i4YAqwUPXhg1gdYRAJTJ6nnrNRzOuwUMIETRUHezzHG 4gGOdTssck2QNruMQFpwGILCFVQ+udkamIijw+P0lAuI5IJMK4mpbG6zTXt5sN08xWWD oKSS0LMdgRoOyhHCxjlqgAIQkF0dpt6QQrRt6gkbA5AUeGeqj/5zByrTXozPhSh7D2nn fr5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+QUdzuKCt2vIM6GeENeuSg4pDrygiUIt0KhoCO356dU=; b=bY7SlLZDM8i/J9h9ZvXHZJKJoE4v+zR/wyVlTOCy7Nn0ulUboCiVs3hbywlHzArosy CW7KYzANZrqWzRL3qOdyI1A/DcAqknsLZGUTetu9O/lHYyYr8iwLNqxNl3KicUBOWG4V edMHiZW4GVTMsV9kxz5ZydAFYgjUItP1xivEqsxlrcpHsEZCGlmdS5B+aJFA8hde/uFB F0cPmTsuBZuxsBLfGjAYgc0wmOXlUrK5j+VcJdTplnnbDPMtI50S9OrVD1oXjdMJtYqQ GszJhBzrGA1LMYsL3WE5pdcLBV0+jiBt1GjE8Ca3a47wPqK5H5g+8xGrKftiStowvA/0 FBAA== X-Gm-Message-State: APjAAAWXKQYHgZWAs+k3UYklTx1SjgOyMDFU7DnsTa1SzpBzuaSQ+wSz dH+yliUZ8cYFLSbZ70bcz63RVOHFxTr5p/Gk+GXhaQ== X-Google-Smtp-Source: APXvYqw/oIjJPMT3XUQlWG/4+uW2SZzD8JyYb9Rz1+Iob8TFx3UKD4E0ph9oiAI1/fqiHomVcfiXbAb6X51FrHA4v5E= X-Received: by 2002:aca:570d:: with SMTP id l13mr432953oib.146.1578416774106; Tue, 07 Jan 2020 09:06:14 -0800 (PST) MIME-Version: 1.0 References: <87imlnjj05.fsf@linaro.org> In-Reply-To: <87imlnjj05.fsf@linaro.org> From: Peter Maydell Date: Tue, 7 Jan 2020 17:06:03 +0000 Message-ID: Subject: Re: race condition in tests/fp/Makefile To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::231 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 7 Jan 2020 at 17:04, Alex Benn=C3=A9e wrot= e: > Peter Maydell writes: > > Also, should we change tests/vm to separately invoke > > 'make' and 'make check' ? I think that doing a single > > 'make check' is a bit fragile because we don't > > really test it and there's no rule that says > > "check depends on all" or similar AFAIK. > > OK - although shouldn't our rules be robust enough for this. Ideally, you might hope that -- but I'm a bit sceptical that we really correctly express all the dependencies that every test has on the build having actually built the things it needs to build... -- PMM