From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>
Subject: Re: [PATCH v3] iotests: Drop readlink -f
Date: Mon, 14 Sep 2020 17:08:27 +0100 [thread overview]
Message-ID: <CAFEAcA-okX+R9+UvtqsJCDJDP_7OSqPOWu-BFReSX225LOkH7g@mail.gmail.com> (raw)
In-Reply-To: <06b0ec10-34d0-05ab-7511-ac7878a6282a@redhat.com>
On Mon, 14 Sep 2020 at 17:03, Eric Blake <eblake@redhat.com> wrote:
> If CDPATH is set, this can produce wrong results. Do we care? Probably
> not, since (as you point out), $source_iotests has the same bug, and no
> one has complained yet.
This has come up previously -- configure and probably most
of our other shell scripts will also break in the presence
of CDPATH. I stand by my position that CDPATH is a bad
misfeature that the shell should not be applying to
scripts. If anybody ever reports a bug we could I suppose
unconditionally unset CDPATH at the top of all our scripts.
thanks
-- PMM
prev parent reply other threads:[~2020-09-14 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 14:56 [PATCH v3] iotests: Drop readlink -f Max Reitz
2020-09-14 15:43 ` Thomas Huth
2020-09-14 16:03 ` Peter Maydell
2020-09-14 16:04 ` Eric Blake
2020-09-14 16:03 ` Eric Blake
2020-09-14 16:08 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-okX+R9+UvtqsJCDJDP_7OSqPOWu-BFReSX225LOkH7g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).