From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
QEMU-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.
Date: Fri, 5 Aug 2011 19:44:02 +0100 [thread overview]
Message-ID: <CAFEAcA-om-b8_VatXVeFDJBd_+eViQ20q3TOG9hvUSG4zFR29g@mail.gmail.com> (raw)
In-Reply-To: <4E3C1FFF.8070409@codemonkey.ws>
On 5 August 2011 17:53, Anthony Liguori <anthony@codemonkey.ws> wrote:
> You'll break some GCCs with -Wall -Werror with this. Please do:
>
> if ((val & E1000_CTRL_RST)) {
Hmm? There's lots of examples of that in the codebase:
$ git grep 'if ([a-zA-Z]* & ' | wc -l
1558
'=' (assignment) needs those extra braces, but logical
ops don't AFAIK.
-- PMM
next prev parent reply other threads:[~2011-08-05 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 14:36 [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set Anthony PERARD
2011-08-05 16:53 ` Anthony Liguori
2011-08-05 18:34 ` Richard Henderson
2011-08-05 18:44 ` Peter Maydell [this message]
2011-08-09 14:10 ` Anthony PERARD
2011-08-09 17:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-om-b8_VatXVeFDJBd_+eViQ20q3TOG9hvUSG4zFR29g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).