From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpPNN-0001eq-Ar for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpPNM-00031b-AT for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:44:05 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:48020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpPNM-00031W-6o for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:44:04 -0400 Received: by yxt3 with SMTP id 3so2171137yxt.4 for ; Fri, 05 Aug 2011 11:44:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E3C1FFF.8070409@codemonkey.ws> References: <1312554976-5822-1-git-send-email-anthony.perard@citrix.com> <4E3C1FFF.8070409@codemonkey.ws> Date: Fri, 5 Aug 2011 19:44:02 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony PERARD , QEMU-devel On 5 August 2011 17:53, Anthony Liguori wrote: > You'll break some GCCs with -Wall -Werror with this. =C2=A0Please do: > > if ((val & E1000_CTRL_RST)) { Hmm? There's lots of examples of that in the codebase: $ git grep 'if ([a-zA-Z]* & ' | wc -l 1558 '=3D' (assignment) needs those extra braces, but logical ops don't AFAIK. -- PMM