From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA209C56202 for ; Wed, 25 Nov 2020 19:29:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03305206D9 for ; Wed, 25 Nov 2020 19:29:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TBbtONhB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03305206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki0Ti-0000bq-CT for qemu-devel@archiver.kernel.org; Wed, 25 Nov 2020 14:29:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki0T0-0000AP-NV for qemu-devel@nongnu.org; Wed, 25 Nov 2020 14:28:38 -0500 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]:33398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki0Sy-0004Pn-U5 for qemu-devel@nongnu.org; Wed, 25 Nov 2020 14:28:38 -0500 Received: by mail-ej1-x642.google.com with SMTP id 7so4662290ejm.0 for ; Wed, 25 Nov 2020 11:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pYWXnELe/62lDRed6k1bFpzeWnpVKLmKnRZnlKHoTRs=; b=TBbtONhBeCYs68mnUvvnni4CgbUNvfVakJOcNOW8qsjPBWU4OydeioaEa9b2+fbPh8 DMFaZ4zrtJv2Bb3eA7EUuYAZg5MdyH+6X9QYjU4bmbLotAsfeozsRA/pGyweaTB0h6hi 99sQVRIDBpgl4fiXGpZ5npV4ztsMK7vfwyoksOof5yMqpyZfnBs9tJpDo0zpGyAzTTJg U2CCrLMMCOTVNCDLAKqgw/j5Nrwc01jtjBE2vsIZg/aeUAZrMeb+gVJkyHU4v8zEEWJi D+24ib9OCNrVWh45dr8pYiwduHSLEpPVBVE+yVCgF8s2+gO17i5q4a+Luu7WONZvJKpj fomA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pYWXnELe/62lDRed6k1bFpzeWnpVKLmKnRZnlKHoTRs=; b=JiS0P5bSU+oKjrXtmw/c6HCoW3AQIfkxL0WbAFDWLqBpJsiQuKMvSelp/9LWX8gZNN KTiqD3V61VLAVEL0eu8xTq8m1kqFrFjsEkrMLGwCUuy1tu7bYvPQ/gBsRd+3m/Ez9epW MizoOj7b1ID2uj3P0Uk/XtfBhS4SgbDHZtw/7wGweRdoU49I9FxeBeFJ8RByJ7mjkd3r e/bAStsRwKbNIbmHq0CNTfvarm7iXGppFQmNz2OE3+3szFPZPyR0H+i4vvV9hb/MrGyA bcQlkTjjva9xC6+18gqxMM84UJrQi/xBA50xkFaPewffutbbDbfxj4LSSYvTgQCy8eLa bOmA== X-Gm-Message-State: AOAM530flwXEtP9nNE0pBrMe21hejW1fIJDVzC0t6S9QjBpO7N6+yFgq SqKZMcYoo1Q58wzcGtP6+Pjd2Np8dfULp+tbORuTGg== X-Google-Smtp-Source: ABdhPJyYp3fgqYEaqKvMH2JFOsyu1iL8HEDIsOBoyiKDTeTvxw0XPjZaADQSItV0Rj3IXZh2oljVIat/WGTBJtvwirI= X-Received: by 2002:a17:906:2741:: with SMTP id a1mr3846321ejd.85.1606332514355; Wed, 25 Nov 2020 11:28:34 -0800 (PST) MIME-Version: 1.0 References: <20201125191833.964753-1-sw@weilnetz.de> In-Reply-To: <20201125191833.964753-1-sw@weilnetz.de> From: Peter Maydell Date: Wed, 25 Nov 2020 19:28:23 +0000 Message-ID: Subject: Re: [PATCH for-5.2] nsis: Fix build for 64 bit installer To: Stefan Weil Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::642; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , QEMU Developers , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 25 Nov 2020 at 19:23, Stefan Weil wrote: > > Pass cpu instead of cpu_family to the NSIS installer script. > > That script checks for "x86_64" which is the cpu value, > while cpu_family is "x86". > > Signed-off-by: Stefan Weil > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Very unfortunate that this has only surfaced after rc3, which should in theory be the cutoff point for 5.2 changes. Is it possible to get something into the CI/make check so that we find Windows installer issues sooner? thanks -- PMM