From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"Denis V. Lunev" <den@openvz.org>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers
Date: Fri, 28 Jul 2017 13:19:57 +0100 [thread overview]
Message-ID: <CAFEAcA-oowaaK9Amn2Achj4a7X-HGOYgNF_7M=rmdOzbick3JA@mail.gmail.com> (raw)
In-Reply-To: <06a9ae13-4279-1210-0664-0faf5f55f830@redhat.com>
On 28 July 2017 at 13:08, Eric Blake <eblake@redhat.com> wrote:
> On 07/28/2017 04:04 AM, Peter Maydell wrote:
>> On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy
>> <vsementsov@virtuozzo.com> wrote:
>>> To make logs more readable prefix all hex values with '0x' mark.
>>> This is needed for consistency too, as a lot of hex values are already
>>> prefixed with '0x'. Also, bring all hex outputs to the common form -
>>> use '%#', not '0x%'.
>>>
>>> This patch is done by two commands:
>>> find . -name trace-events | \
>>> xargs sed -i 's/%\([-+ *.0-9]*\([hljztL]\|ll\|hh\)\?\(x\|X\|"\s*PRIx\)\)/%#\1/g'
>
> Why PRIx32 but not PRIX32?
As it happens none of our trace-events files use PRIX...
thanks
-- PMM
next prev parent reply other threads:[~2017-07-28 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 8:55 [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers Vladimir Sementsov-Ogievskiy
2017-07-28 9:04 ` Peter Maydell
2017-07-28 9:19 ` Vladimir Sementsov-Ogievskiy
2017-07-28 12:08 ` Eric Blake
2017-07-28 12:19 ` Peter Maydell [this message]
2017-07-28 12:40 ` Eric Blake
2017-07-28 9:06 ` Daniel P. Berrange
2017-07-28 9:14 ` Vladimir Sementsov-Ogievskiy
2017-07-28 9:41 ` Cornelia Huck
2017-07-28 10:01 ` Vladimir Sementsov-Ogievskiy
2017-07-28 11:30 ` Cornelia Huck
2017-07-28 12:05 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-oowaaK9Amn2Achj4a7X-HGOYgNF_7M=rmdOzbick3JA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).