From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SsECw-0001ZP-RN
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 10:29:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SsECs-0004p1-1u
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 10:29:30 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:59604)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SsECr-0004oe-Rf
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 10:29:25 -0400
Received: by bkcji1 with SMTP id ji1so2990797bkc.4
	for <qemu-devel@nongnu.org>; Fri, 20 Jul 2012 07:29:25 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1341589767-9895-3-git-send-email-m.kozlov@samsung.com>
References: <1341589767-9895-1-git-send-email-m.kozlov@samsung.com>
	<1341589767-9895-3-git-send-email-m.kozlov@samsung.com>
Date: Fri, 20 Jul 2012 15:29:24 +0100
Message-ID: <CAFEAcA-pt4GDCv47phGV5ezPxuu830gJcOXptX3PjpM6w=V8Zw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/4] ARM: exynos4210_pmu: changes in
	PRINT_DEBUG macro set.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Maksim Kozlov <m.kozlov@samsung.com>
Cc: kyungmin.park@samsung.com, qemu-devel@nongnu.org

On 6 July 2012 16:49, Maksim Kozlov <m.kozlov@samsung.com> wrote:

> Subject: ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set.

This is a rather vague summary.

> It make possible to set DEBUG_PMU and DEBUG_PMU_EXTEND

"This makes it possible"

> independently of each other

The patch doesn't actually do this, though -- if you set
DEBUG_PMU_EXTEND you always get DEBUG_PMU's effects even
if DEBUG_PMU isn't set.

Plus you have two versions of the "do nothing" version of
PRINT_DEBUG_EXTEND, which isn't very pretty.

The patch also introduces the new PRINT_ERROR without mentioning
it in the commit message.

> +#if DEBUG_PMU || DEBUG_PMU_EXTEND
> +
> +    #define  PRINT_DEBUG(fmt, args...)  \

Indenting preprocessor defines with space before the "#" rather
than after definitely puts you in the minority:

$ git grep '^#\s\+define' | wc -l
862
$ git grep '^\s\+#define' | wc -l
126

-- PMM