From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adwVq-0006Az-RA for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:04:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adwVl-0001Zw-74 for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:04:06 -0500 Received: from mail-vk0-x22e.google.com ([2607:f8b0:400c:c05::22e]:35603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adwVj-0001Zk-VI for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:04:01 -0500 Received: by mail-vk0-x22e.google.com with SMTP id e6so87794896vkh.2 for ; Thu, 10 Mar 2016 01:03:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20160223190905.65sroj2tysb22hbz@hawk.localdomain> References: <1456175198-25210-1-git-send-email-wei@redhat.com> <56CCA649.8090906@redhat.com> <20160223190905.65sroj2tysb22hbz@hawk.localdomain> From: Peter Maydell Date: Thu, 10 Mar 2016 16:03:39 +0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH RFC 0/2] Versioning ARM virt machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: Wei Huang , qemu-arm , QEMU Developers , Andrea Bolognani On 24 February 2016 at 02:09, Andrew Jones wrote: > I believe our downstream versioning has driven some changes to libvirt > already, so I think it's a good time to bring the how to best version > mach-virt discussions to all the respective upstreams, despite it > currently, at least for us, being used only on pre-releases though. So, to sum up from a conversation today: * We should add versioning to 'virt' now * We should do it by having the QEMU 2.6 release have a "virt-2.6" which is the same as "virt" for this upstream release * Then from 2.6 forward we start creating "virt-2.7", etc machines and making sure we have properties etc so that "virt-2.6" remains the same config as the 2.6 release's virt board. * RedHat are doing this for downstream anyway so will take on the task of monitoring changes to the virt board and submitting the relevant patches to property-ify things. (Better still, if you make comments during code review you can get patch submitters to do the work for you ;-). I will attempt to spot this kind of thing when I review patches to the virt board but I will probably miss things especially at first.) Practically: * Wei, you need to respin this patchset, because as it stands it creates a "virt-2.5", and it should be "virt-2.6". If you do that then I think it's generally OK to go in. * My only other review comment is that patch 1 sets mc->is_default which gives qemu-system-aarch64 a default board. We deliberately don't have a default machine type for ARM, so please don't do that. (We can have that discussion if you like but it's a separate issue so best not tangled up with this patchset.) thanks -- PMM