From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
qemu-devel@nongnu.org, zhur@ispras.ru, batuzovk@ispras.ru,
Peter Crosthwaite <peter.crosthwaite@petalogix.com>,
kyungmin.park@samsung.com, paul@codesourcery.com,
duyl@xilinx.com, linnj@xilinx.com, edgar.iglesias@gmail.com,
john.williams@petalogix.com
Subject: Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version
Date: Tue, 19 Jun 2012 11:55:32 +0100 [thread overview]
Message-ID: <CAFEAcA-qjH6KNXAoMPgm4J9J4iFDF8p6sDBts==whwTuGDGoRA@mail.gmail.com> (raw)
In-Reply-To: <4FE051B5.6020904@suse.de>
On 19 June 2012 11:17, Andreas Färber <afaerber@suse.de> wrote:
> Am 19.06.2012 08:40, schrieb Peter Crosthwaite:
>> On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko
>>> And it still has no save/load support, it is really mandatory for all new
>>> devices. I can recall that one of the maintainers wrote a while ago that
>>> every device at least needs to mark itself as non-migratable, if it doesn't
>>> implement a proper vmstate.
>>>
>> Ok, ccing Andreas
>
> Not my requirement but Peter's (cc'ing). Usually it's really trivial
> adding a handful of fields to the VMSD, so I can understand though.
Yes, it's not difficult and there's no easy way to detect "attempted
to migrate a machine using a device that failed to implement save/load"
so I prefer to be strict about not letting new devices into the tree
that don't implement this. (Proper implementation, please, not just
marking the device as non-migratable.)
-- PMM
next prev parent reply other threads:[~2012-06-19 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 0:42 [Qemu-devel] [PATCH v4 0/2] Xilinx Zynq PL330 support Peter A. G. Crosthwaite
2012-06-18 0:42 ` [Qemu-devel] [PATCH v4 1/2] pl330: initial version Peter A. G. Crosthwaite
2012-06-18 14:33 ` Igor Mitsyanko
2012-06-19 6:40 ` Peter Crosthwaite
2012-06-19 10:17 ` Andreas Färber
2012-06-19 10:55 ` Peter Maydell [this message]
2012-07-03 11:30 ` Igor Mitsyanko
2012-07-05 4:44 ` Peter Crosthwaite
2012-07-05 17:51 ` Igor Mitsyanko
2012-07-06 1:33 ` Peter Crosthwaite
2012-06-18 0:42 ` [Qemu-devel] [PATCH v4 2/2] xilinx_zynq: added pl330 to machine model Peter A. G. Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-qjH6KNXAoMPgm4J9J4iFDF8p6sDBts==whwTuGDGoRA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=batuzovk@ispras.ru \
--cc=duyl@xilinx.com \
--cc=edgar.iglesias@gmail.com \
--cc=i.mitsyanko@samsung.com \
--cc=john.williams@petalogix.com \
--cc=kyungmin.park@samsung.com \
--cc=linnj@xilinx.com \
--cc=paul@codesourcery.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
--cc=zhur@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).