From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Sgw60-0001cQ-4w
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 06:55:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Sgw5w-00040R-5A
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 06:55:39 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:60628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Sgw5v-000404-Uh
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 06:55:36 -0400
Received: by bkwj10 with SMTP id j10so5224424bkw.4
	for <qemu-devel@nongnu.org>; Tue, 19 Jun 2012 03:55:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4FE051B5.6020904@suse.de>
References: <cover.1339979922.git.peter.crosthwaite@petalogix.com>
	<15126b43916ee3b1db4eafe3b0fabfcbfc8c0584.1339979922.git.peter.crosthwaite@petalogix.com>
	<4FDF3C1C.1020008@samsung.com>
	<CAEgOgz4TJcXW4ro5cF+wtuj3FGYbWeqg2GGKuiswLXoe1vBpdw@mail.gmail.com>
	<4FE051B5.6020904@suse.de>
Date: Tue, 19 Jun 2012 11:55:32 +0100
Message-ID: <CAFEAcA-qjH6KNXAoMPgm4J9J4iFDF8p6sDBts==whwTuGDGoRA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>, qemu-devel@nongnu.org, zhur@ispras.ru, batuzovk@ispras.ru, Peter Crosthwaite <peter.crosthwaite@petalogix.com>, kyungmin.park@samsung.com, paul@codesourcery.com, duyl@xilinx.com, linnj@xilinx.com, edgar.iglesias@gmail.com, john.williams@petalogix.com

On 19 June 2012 11:17, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 19.06.2012 08:40, schrieb Peter Crosthwaite:
>> On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko
>>> And it still has no save/load support, it is really mandatory for all n=
ew
>>> devices. I can recall that one of the maintainers wrote a while ago tha=
t
>>> every device at least needs to mark itself as non-migratable, if it doe=
sn't
>>> implement a proper vmstate.
>>>
>> Ok, ccing =C2=A0Andreas
>
> Not my requirement but Peter's (cc'ing). Usually it's really trivial
> adding a handful of fields to the VMSD, so I can understand though.

Yes, it's not difficult and there's no easy way to detect "attempted
to migrate a machine using a device that failed to implement save/load"
so I prefer to be strict about not letting new devices into the tree
that don't implement this. (Proper implementation, please, not just
marking the device as non-migratable.)

-- PMM