From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FDE0C433E1 for ; Mon, 24 Aug 2020 16:40:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F105322BED for ; Mon, 24 Aug 2020 16:40:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iJQrFbsr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F105322BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAFW4-0003hH-AE for qemu-devel@archiver.kernel.org; Mon, 24 Aug 2020 12:40:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAFVU-0003Ad-2L for qemu-devel@nongnu.org; Mon, 24 Aug 2020 12:39:40 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:39894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAFVS-0007lb-Im for qemu-devel@nongnu.org; Mon, 24 Aug 2020 12:39:39 -0400 Received: by mail-ej1-x62b.google.com with SMTP id md23so12000823ejb.6 for ; Mon, 24 Aug 2020 09:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KUC5lQUeddxNURzwEfpyNte4kdBhJoq871krNkhUnvE=; b=iJQrFbsrvKACOJhPS0KLuglagXanIhT7Q3T/Z53ANU08keJFePwzublDmOi0HDwRl+ l635nVJNw8ntx3C76yte14dqsfRHK1Xk9+cqFIgBkOrxLEA1u1mCa12dST6d23Rv42Bn 8+wiarJFreVZW8Udn18ZapD6+ckbWkHW0gSekkRAM952J5IaEAy50p+/OxuCIk2KdH8C ymNtuITGtiVekb4r+i7uu6vvRRCwOxeb7MWSeRrfoC/avkYm8ijWbDC4APURY+cTMwkf hTS5zuIkf29GHeLVirmtxc58qlNcQUmz1veFKNKRohxGQj5S7SSsIfps2dROmiLnA8M9 P0bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KUC5lQUeddxNURzwEfpyNte4kdBhJoq871krNkhUnvE=; b=dlVlPMrcZdCoD5Q0SDsO64tI8brX9fcVmhxeYYW+CpUGB3pvz8T/mV1RiL5y/22mP0 DwyvxXd11I7iCsJs3p5zE2VnRTpJI2DzCDIQYgkLrO53IMFXlx8yEn79pMRQI0am4gQi bpns8wYNV4LaDXiOG5v1NPC+QmyqtbniraXhsRmx/2UT83mATJ9RtMQAZDwCqk/4wjnE U8eA2Bp9o0qbFBjFUKW07w3QpMPTF5VFTupOb6j01Ki9TV10cTGqOIyW+ywZjNS6/8aL +gQiFC3ILwPbN2jDnVKndsWrwxf8Ok492vmHM0jFxINowwZt9YZT2gaBm5+OWGjcHBxh AeLw== X-Gm-Message-State: AOAM5327mW0MnTn0RA4qQrYZVnvr9i7sUHzTphJM/uA/utjDbHtN8E7w yHqeM0VypkWBVdk93ERJoGqMvxtdKmP/7mjnm+4Glg== X-Google-Smtp-Source: ABdhPJxFSs05zvK/TxaoLPwfoARfIHM4C2M2Q7NZABkdipfYK00iXCkvDpvWRu8TAnBL9R4NEp/NSG+OHwntNBlPj84= X-Received: by 2002:a17:906:d8ca:: with SMTP id re10mr6116139ejb.382.1598287176846; Mon, 24 Aug 2020 09:39:36 -0700 (PDT) MIME-Version: 1.0 References: <20200803105647.22223-1-f4bug@amsat.org> In-Reply-To: <20200803105647.22223-1-f4bug@amsat.org> From: Peter Maydell Date: Mon, 24 Aug 2020 17:39:25 +0100 Message-ID: Subject: Re: [PATCH-for-5.1? 0/4] hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Alistair Francis , QEMU Developers , qemu-arm , "Edgar E. Iglesias" , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 3 Aug 2020 at 11:56, Philippe Mathieu-Daud=C3=A9 = wrote: > > This is not a critical issue, but still annoying if you use tracing. > > Maybe it is worth fixing for forks that are based on release tags, > else consider it 5.2 material. > > Anyway we can still discuss if qdev_connect_clock_in() is supposed to > be callable *after* DeviceRealize. > > Philippe Mathieu-Daud=C3=A9 (4): > hw/arm/xilinx_zynq: Uninline cadence_uart_create() > hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize > hw/qdev-clock: Uninline qdev_connect_clock_in() > hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize > Applied to target-arm.next, thanks. -- PMM