From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] segfault on current HEAD, qemu-system-arm
Date: Wed, 5 Oct 2011 14:22:58 +0100 [thread overview]
Message-ID: <CAFEAcA-rA4BCfTAV8FWAf+x380hKj2JVZ25UtY2EHAksBqYvLQ@mail.gmail.com> (raw)
In-Reply-To: <CAAu8pHvmKJh-OHZP+K6PtLJ3hrqDcK16b54u5bCrbWicggH4wQ@mail.gmail.com>
On 2 October 2011 19:44, Blue Swirl <blauwirbel@gmail.com> wrote:
> Bah, bug in bccd9ec5f098668576342c83d90d6d6833d61d33,
> target-arm/op_helper.c missed this change unlike all other targets:
> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
> index ab9c923..1892b35 100644
> --- a/target-arm/op_helper.c
> +++ b/target-arm/op_helper.c
> @@ -84,6 +84,7 @@ void tlb_fill(CPUState *env1, target_ulong addr, int
> is_write, int mmu_idx,
> int ret;
>
> saved_env = env;
> + env = env1;
> ret = cpu_arm_handle_mmu_fault(env, addr, is_write, mmu_idx);
> if (unlikely(ret)) {
> if (retaddr) {
>
This fixes the segfault for me.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
next prev parent reply other threads:[~2011-10-05 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 14:20 [Qemu-devel] segfault on current HEAD, qemu-system-arm Avi Kivity
2011-10-02 18:44 ` Blue Swirl
2011-10-05 13:22 ` Peter Maydell [this message]
2011-10-08 10:16 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-rA4BCfTAV8FWAf+x380hKj2JVZ25UtY2EHAksBqYvLQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).