qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Vijaya Kumar K <vijayak@caviumnetworks.com>
Cc: Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>,
	Vijay <vijayak@cavium.com>, qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Vijay Kilari <vijay.kilari@gmail.com>
Subject: Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking
Date: Tue, 5 Apr 2016 16:28:45 +0100	[thread overview]
Message-ID: <CAFEAcA-rV_rZHkOmbhMw+otPTPBSTZp_Ff_0ZrD_LpK2=TSAMQ@mail.gmail.com> (raw)
In-Reply-To: <1459777195-7907-3-git-send-email-vijayak@caviumnetworks.com>

On 4 April 2016 at 14:39,  <vijayak@caviumnetworks.com> wrote:
> From: Vijay <vijayak@cavium.com>
>
> Use Neon instructions to perform zero checking of
> buffer. This is helps in reducing downtime during
> live migration.

One other comment I forgot:

> +#define NEON_VECTYPE               uint64x2_t

This is a 128-bit type...

> +static size_t buffer_find_nonzero_offset_neon(const void *buf, size_t len)
> +{
> +    size_t i;
> +    NEON_VECTYPE d0, d1, d2, d3, d4, d5, d6;
> +    NEON_VECTYPE d7, d8, d9, d10, d11, d12, d13, d14;

...so it's a bit confusing to use d0, d1, etc, which implies
a 64-bit value.

thanks
-- PMM

      parent reply	other threads:[~2016-04-05 15:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1459777195-7907-1-git-send-email-vijayak@caviumnetworks.com>
2016-04-04 13:39 ` [Qemu-devel] [RFC PATCH v1 1/2] target-arm: Update page size for aarch64 vijayak
2016-04-04 13:44   ` Peter Maydell
2016-04-04 16:40     ` Vijay Kilari
2016-04-04 16:44       ` Peter Maydell
2016-04-06 15:01         ` Vijay Kilari
2016-05-31  9:04           ` Vijay Kilari
2016-05-31  9:31             ` Peter Maydell
2016-04-04 13:39 ` [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking vijayak
2016-04-05 14:36   ` Peter Maydell
2016-04-05 15:21     ` Paolo Bonzini
2016-04-05 16:01       ` Peter Maydell
     [not found]         ` <C94A741879221447B4FC9B607EB4FFCD79EA34F4@DGGEMA504-MBX.china.huawei.com>
2017-03-23 16:56           ` [Qemu-devel] [Qemu-arm] about armv8's prefetch decode Pranith Kumar
2017-03-24  6:14             ` [Qemu-devel] [Qemu-arm] [patch 1/1]about " Wangjintang
2017-03-24 10:06               ` Peter Maydell
2017-03-25  2:22                 ` Wangjintang
2017-03-25 12:35                   ` Peter Maydell
2016-04-06  8:32     ` [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking Vijay Kilari
2016-04-05 15:28   ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-rV_rZHkOmbhMw+otPTPBSTZp_Ff_0ZrD_LpK2=TSAMQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=Prasun.Kapoor@caviumnetworks.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vijay.kilari@gmail.com \
    --cc=vijayak@cavium.com \
    --cc=vijayak@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).