Re: [PATCH v7 08/14] arm/cpu: Store id_isar0-7 into the idregs array

[Peter Maydell <peter.maydell@linaro.org>]

On Thu, 12 Jun 2025 at 16:36, Cornelia Huck <cohuck@redhat.com> wrote:
>
> On Thu, Jun 12 2025, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> > On Thu, 15 May 2025 at 16:40, Cornelia Huck <cohuck@redhat.com> wrote:
> >>
> >> From: Eric Auger <eric.auger@redhat.com>
> >>
> >> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >> Reviewed-by: Sebastian Ott <sebott@redhat.com>
> >> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> >> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> >> ---
> >>  hw/intc/armv7m_nvic.c     |  12 ++--
> >>  target/arm/cpu-features.h |  36 +++++-----
> >>  target/arm/cpu.c          |  24 +++----
> >>  target/arm/cpu.h          |   7 --
> >>  target/arm/cpu64.c        |  28 ++++----
> >>  target/arm/helper.c       |  14 ++--
> >>  target/arm/kvm.c          |  21 ++----
> >>  target/arm/tcg/cpu-v7m.c  |  90 +++++++++++++-----------
> >>  target/arm/tcg/cpu32.c    | 144 +++++++++++++++++++++-----------------
> >>  target/arm/tcg/cpu64.c    | 108 ++++++++++++++--------------
> >>  10 files changed, 243 insertions(+), 241 deletions(-)
> >
> > This doesn't compile:
> >
> > ../../target/arm/tcg/cpu-v7m.c:70:5: error: incompatible pointer types
> > initializing 'ARMISARe
> > gisters *' (aka 'struct ARMISARegisters *') with an expression of type
> > 'uint64_t *' (aka 'unsigned long *')
> > [-Werror,-Wincompatible-pointer-types]
> >    70 |     SET_IDREG(idregs, ID_ISAR0, 0x01141110);
> >       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../../target/arm/cpu.h:875:26: note: expanded from macro 'SET_IDREG'
> >   875 |         ARMISARegisters *i_ = (ISAR);
> >          \
> >       |                          ^    ~~~~~~
> > ../../target/arm/tcg/cpu-v7m.c:71:5: error: incompatible pointer types
> > initializing 'ARMISARegisters *' (aka 'struct ARMISARegisters *') with
> > an expression of type 'uint64_t *' (aka 'unsigned long *')
> > [-Werror,-Wincompatible-pointer-types]
> >    71 |     SET_IDREG(idregs, ID_ISAR1, 0x02111000);
> >       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../../target/arm/cpu.h:875:26: note: expanded from macro 'SET_IDREG'
> >   875 |         ARMISARegisters *i_ = (ISAR);
> >          \
> >       |                          ^    ~~~~~~
> >
> > (and more similar errors until the compiler gives up).
>
> What configs/compiler are you using? I obviously would have fixed that
> if I had hit it...

This is clang 18.1.3 (1ubuntu1) on x86-64 Linux, configured with

'../../configure' '--cc=clang' '--cxx=clang++' '--enable-ubsan'
'--target-list=arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user'

Whatever the problem is, it goes away on a later patch, so probably
it's just that some fragment in a later patch needs to move into
this one.

thanks
-- PMM