Re: [PATCH] RFC: net: document "-netdev user" explicitly as unsafe

[Peter Maydell <peter.maydell@linaro.org>]

On Mon, 7 Jun 2021 at 12:50, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> libslirp is known to have several security flaws, we should make it
> explicit by warning the users and in the documentation.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -388,6 +388,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
>      char *end;
>      struct slirp_config_str *config;
>
> +    warn_report("User mode network stack is unsafe!");

Not enthusiastic about generating new warnings for a huge range
of end-users, especially without detailed information about
what they should do about it and suitable new command lines
(including ones which will work for everybody, not just "I'm
on an x86 PC with pluggable network devices").

Also, -net user is perfectly fine for quite a lot of usecases.

thanks
-- PMM